Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Javadoc Warnings #984

Merged
merged 1 commit into from Jul 8, 2021
Merged

Fixed Javadoc Warnings #984

merged 1 commit into from Jul 8, 2021

Conversation

andygibson
Copy link
Contributor

@andygibson andygibson commented Jun 20, 2021

These were the only lines that raised Javadoc warnings. There were other warnings, that I could look into, but these were the only Javadoc specific ones I saw.

Closing #979

As these are no API changes, this is a fast-track review period of just one day as per our committer rules.

@andygibson
Copy link
Contributor Author

Agh, my Eclipse account is under a different email address than my Github account, hence not having the legal agreements in place. Let me look into that.

@mkarg mkarg self-assigned this Jun 21, 2021
@mkarg mkarg added the javadoc label Jun 21, 2021
@mkarg mkarg added this to To do in Release.next via automation Jun 21, 2021
@mkarg mkarg added this to the 3.1 milestone Jun 21, 2021
Copy link
Contributor

@mkarg mkarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@mkarg
Copy link
Contributor

mkarg commented Jun 21, 2021

@andygibson Do you also like to fix the JavaDoc warnings found in the examples subproject? :-)

(You need to do mvn javadoc:javadoc to see them)

Copy link
Contributor

@andymc12 andymc12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@andygibson andygibson mentioned this pull request Jun 21, 2021
@spericas spericas removed this from To do in Release.next Jul 7, 2021
@spericas spericas added this to To do in Jakarta REST 3.1 Jul 7, 2021
@spericas spericas moved this from To do to In progress in Jakarta REST 3.1 Jul 7, 2021
@mkarg mkarg merged commit 0304a92 into jakartaee:master Jul 8, 2021
@mkarg mkarg moved this from In progress to Done in Jakarta REST 3.1 Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants