QueryParameterProcessor could not handle lower-case in enum string value

[jerseyrobot]

Jersey get IllegalArgumentException with query param of JAX-B generated type like:

@XmlType(name = "casingEnum")
@XmlEnum
public enum CasingEnum {

@XmlEnumValue("Upper")
UPPER("Upper"), @XmlEnumValue("Lower")
LOWER("Lower"),
@XmlEnumValue("Proper")
PROPER("Proper");
private final String value;

CasingEnum(String v)

{ value = v; }

public String value()

{ return value; }

public static CasingEnum fromValue(String v) {
for (CasingEnum c: CasingEnum.values()) {
if (c.value.equals(v))

{ return c; }

}
throw new IllegalArgumentException(v);
}
}

Environment

Operating System: All
Platform: All

[jerseyrobot]

@glassfishrobot Commented
Reported by ntn@java.net

[jerseyrobot]

@glassfishrobot Commented
Was assigned to sandoz@java.net

[jerseyrobot]

@glassfishrobot Commented
ntn@java.net said:
Created an attachment (id=7)
Thread dump of Enum.valueOf invocation

[jerseyrobot]

@glassfishrobot Commented
File: threaddump.txt
Attached By: ntn@java.net

[jerseyrobot]

@glassfishrobot Commented
ntn@java.net said:
IMHO, the correct fix for this is from JAX-B wsimport code generation. By using
all uppercase for enum name, there would be great chance of disconnection with
the schema-specified enumeration values. For example, how JAX-B would generate
enum class for:

<s:simpleType name="EnglishCharacter">
<s:restriction base="s:string">
<s:enumeration value="A"/>
....
<s:enumeration value="a"/>
....
</s:restriction>
</s:simpleType>

An alternate solution for this issue is make Jersey be a little more supportive
of JAX-B by also check for a method named 'fromValue' on the enum type. But
this is really a brittle contract.

[jerseyrobot]

@glassfishrobot Commented
sandoz@java.net said:
The problem with relying on JAXB generated field names is that there could be
some characters in the enumeration values that are illegal as characters of
field names.

You are right about brittle contracts. I think we need to review this whole area
and see if there is a more general and less brittle way.

The following links contain more use-cases/issues in this area:

https://jersey.dev.java.net/servlets/ReadMsg?list=users&msgNo=294

https://jersey.dev.java.net/issues/show_bug.cgi?id=15

[jerseyrobot]

@glassfishrobot Commented
ntn@java.net said:
You are right, I totally forgot about enum names actually have general Java name
constraint. Some spi for generic type converter specified at application level
would be enough, i think.

[jerseyrobot]

@glassfishrobot Commented
sandoz@java.net said:
This is a duplicate of issue 15

• • • This issue has been marked as a duplicate of 15 ***

[jerseyrobot]

@glassfishrobot Commented
Marked as duplicate on Monday, January 14th 2008, 7:29:14 pm

[jerseyrobot]

@glassfishrobot Commented
This issue was imported from java.net JIRA JERSEY-26

[jerseyrobot]

• Issue Imported From: https://github.com/jersey/jersey/issues/298
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @mpotociar
• Original Issue Closed By:@glassfishrobot