Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JacksonFeature configurable #5052

Closed
Deymus opened this issue Apr 26, 2022 · 0 comments · Fixed by #5074
Closed

Make JacksonFeature configurable #5052

Deymus opened this issue Apr 26, 2022 · 0 comments · Fixed by #5074
Milestone

Comments

@Deymus
Copy link

Deymus commented Apr 26, 2022

At present time there is no any possibility define witch modules would be registered in DefaultJacksonJaxbJsonProvider.
Current implementation of DefaultJacksonJaxbJsonProvider imports all modules(except JaxbAnnotationModule) founded in classpath. That leads to problem with unwanted modules would be registered. In example, we have jetty + jersey web server and we adding kafka to our application. Kafka has runtime dependencies to Jdk8 and Skala modules. Skala has jackson version check and any other modules can has it too. Its can create situation when auto registered 2 modules has non-overlapping version range check,wich cant be fixed by simple change jackson version.

My proposal to make registered modules in DefaultJacksonJaxbJsonProvider more configurable.
It can be achieved by

  1. Make DefaultJacksonJaxbJsonProvider extendable with overriding findAndRegisterModules method
  2. Make JacksonFeature configurable to replace registration of DefaultJacksonJaxbJsonProvider by customized one
@senivam senivam linked a pull request Jun 2, 2022 that will close this issue
@senivam senivam added this to the 2.36 milestone Jun 9, 2022
This was referenced Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants