Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique index creation #361

Closed
dreab8 opened this issue Feb 15, 2022 · 9 comments
Closed

Unique index creation #361

dreab8 opened this issue Feb 15, 2022 · 9 comments
Labels
accepted Accepted certification request challenge TCK challenge

Comments

@dreab8
Copy link

dreab8 commented Feb 15, 2022

The com/sun/ts/tests/jpa/se/schemaGeneration/annotations/index/Client.java#indexTest test checks for the unique index creation that the generated schema creation script contains
ALTER TABLE SCHEMAGENSIMPLE ADD UNIQUE INDEX SCHEMAGENSIMPLE_SVALUE3 or CREATE UNIQUE INDEX SCHEMAGENSIMPLE_SVALUE3 ON SCHEMAGENSIMPLE (SVALUE3) and it fails if
ALTER TABLE SCHEMAGENSIMPLE ADD CONSTRAINT SCHEMAGENSIMPLE_SVALUE3 UNIQUE (SVALUE3) is generated instead.

@scottmarlow
Copy link
Contributor

@dreab8 as mentioned in https://jakarta.ee/committees/specification/tckprocess/, this issue needs the challenge label to initiate a TCK challenge.

@beikov
Copy link

beikov commented Feb 18, 2022

Note that we can't add a challenge label to the issue

@lukasj lukasj added the challenge TCK challenge label Feb 18, 2022
@lukasj
Copy link
Contributor

lukasj commented Feb 18, 2022

label added; note that any committer is able to do that

@scottmarlow
Copy link
Contributor

As per https://jakarta.ee/committees/specification/tckprocess, approval is the default after 14 days (March 4 I think), unless the challenge is accepted/denied before then.

@lukasj lukasj added the accepted Accepted certification request label Mar 4, 2022
@lukasj
Copy link
Contributor

lukasj commented Mar 4, 2022

I believe this is purely TCK issue and since it has been resolved there already, time to close this.

@beikov
Copy link

beikov commented Mar 4, 2022

Sure, but we would like the challenge to be accepted so that we can exclude the test from the 3.0 TCK

@lukasj
Copy link
Contributor

lukasj commented Mar 4, 2022

you don't see the label added about an hour ago?

@beikov
Copy link

beikov commented Mar 4, 2022

Sorry, I didn't look careful enough before. All fine :)

@lukasj
Copy link
Contributor

lukasj commented Mar 4, 2022

ok

@lukasj lukasj closed this as completed Mar 4, 2022
scottmarlow added a commit to jakartaee/platform-tck that referenced this issue Mar 4, 2022
Signed-off-by: Scott Marlow <smarlow@redhat.com>
scottmarlow added a commit to jakartaee/platform-tck that referenced this issue Mar 5, 2022
…aee/persistence#350 and also increment Persistence TCK version to 3.0.2

Signed-off-by: Scott Marlow <smarlow@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted certification request challenge TCK challenge
Projects
None yet
Development

No branches or pull requests

4 participants