Resolving failing TCK #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Maybe (!!!) fixes race condition in GlassFish. Since this change the TCK jstl/spec/xml/xmlcore/types passed several times without failing. However, I am still not convinced, because the failure wasn't well reproducible and also the cause wasn't clearly visible. - XPathUtil doesn't set system properties any more (see XPathUtil). - DocumentBuilderFactory should not be used as a constant, it is not thread-safe. Despite in this case I doubt it could cause issue, I cannot be sure. - Deleted unused methods - JSTLNodeList moved to own file - Deleted copy pasted javadocs from old versions - More should be done, but let's start with this. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
dmatej
force-pushed
the
xpathfactory
branch
from
d990dfc
to
2ccb17a
Compare
arjantijms
approved these changes
Sep 26, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: partial cleanup in xml package.
cd /repo/git/jstl && mvn clean install && cd /repo/git/glassfish-beta && mvn clean install -Pfastest -T4C -Djstl-impl.version=3.0.1-SNAPSHOT && mvn clean install -Ptck -pl :tck-runner -Dit.test=CustomITest -Dtck.module=jstlOr to run those randomly failing tests directly use
-Dtck.module=jstl/spec/xml/xmlcore/typesNote: I tried to replace the JSTLXPathFactory by the factory from the JDK, but that failed, it needs more work, perhaps later.
TCK results with GlassFish 7.0.0-SNAPSHOT near to M9, commit e821a1a6a86fce6daa06db203bdd7676231bbec7