Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jakartify JSTL-API/IMPL including merge of EE4J_8 branch into master #47

Merged
merged 7 commits into from Mar 4, 2020
Merged

Jakartify JSTL-API/IMPL including merge of EE4J_8 branch into master #47

merged 7 commits into from Mar 4, 2020

Conversation

senivam
Copy link
Contributor

@senivam senivam commented Mar 4, 2020

No description provided.

ggam and others added 7 commits September 19, 2018 23:46
@ggam @m0mus
Changed groupId and artifactId. Fixes jakartaee#3 (jakartaee#5)
a074621 
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
@senivam @m0mus
Ready scripts for CI/CD builds and release jobs (jakartaee#10)
ea8739d 
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
@senivam @m0mus
Release + CI/CD for master and EE4J branches (jakartaee#11)
de0802b 
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
@senivam @m0mus
Legal files added to target (jakartaee#17)
64594d9 
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
@m0mus
Dependencies update (jakartaee#18)
b4cbe35 
Signed-off-by: Dmitry Kornilov <dmitry.kornilov@oracle.com>
@lukasj @m0mus
Adopt recent jakarta dependencies, fix GF integration issues (jakarta…
aeea88a 
…ee#19)

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@senivam
migration from javax to jakarta
7dc67c3 
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
@senivam senivam mentioned this pull request Mar 4, 2020
Closed
m0mus
m0mus approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m0mus
Copy link
Contributor

m0mus commented Mar 4, 2020

Please fix the ECA check and I am ready to merge it.

@senivam
Copy link
Contributor Author

senivam commented Mar 4, 2020

actually the merge already contains invalid commits. My last commit contains valid ECA sign-off but the whole merge as per report is not fully compatible:

Guillermo González de Agüero (ggam@****.noreply) did not include the "Signed-off-by footer" which is required for all commits made by a contributor.
Maxim Nesen (24524084+senivam@****.noreply) did not include the "Signed-off-by footer" which is required for all commits made by a contributor.
Anonymous (maiden168@****.com) is not covered by the necessary legal agreements in order to proceed.

@m0mus
Copy link
Contributor

m0mus commented Mar 4, 2020

maiden168 is my account and I am covered by ECA. So, everything looks fine. Merging.

@m0mus m0mus merged commit 885432c into jakartaee:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0mus m0mus m0mus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@senivam @m0mus @ggam @lukasj