Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec Cleanup Step 2: Modifying references to the JCP with corresponding Eclipse processes #103

Closed
tomjenkinson opened this issue Jun 11, 2020 · 12 comments

Comments

@tomjenkinson
Copy link
Contributor

Please see the related information here:
https://github.com/jakartaee/specification-committee/blob/master/steps_javaee_to_jakartaee.adoc

The relevant branch is over here:
https://github.com/eclipse-ee4j/jta-api/tree/spec-document-conversion

@tomjenkinson
Copy link
Contributor Author

It could be general Java EE process references, JCP and so on. If there are non, please confirm back here!

@tomjenkinson
Copy link
Contributor Author

Also, a note that if you are the first person to edit a file in the year, please update the copyright to include 2020

@vanuatoo
Copy link
Contributor

Started working on the issue

@vanuatoo
Copy link
Contributor

Should I wait for this PR merged and then start working on the issue?
#107

@tomjenkinson
Copy link
Contributor Author

@vanuatoo #107 is merged now but I would hope it would not have interfered with your work as it should have been a separate change. Thanks for checking.

@vanuatoo
Copy link
Contributor

vanuatoo commented Jun 16, 2020

All the JCP references except Jakarta Enterprise Beans 4.0 are addressed by #125 from #104
If Jakarta Enterprise Beans 4.0 reference is added in PR 125, nothing will be left to do for this issue.

@tomjenkinson
Copy link
Contributor Author

I think #125 should add the Jakarta Enterprise Beans in hopefully. Thanks for reviewing, let's keep this open till #104 is closed and then re-review? If you are happy to do so there are several other specification issues available in the meantime?

@tomjenkinson
Copy link
Contributor Author

#125 is merged, @vanuatoo please may I ask you to double check the state of https://github.com/eclipse-ee4j/jta-api/tree/spec-document-conversion regarding #103?

@vanuatoo
Copy link
Contributor

I made some small changes and want to push my branch to open PR but I get permission denied.

@tomjenkinson
Copy link
Contributor Author

@vanuatoo if I am following you correctly, I think you may have tried to push direct into this repo? Please can you fork the repo and raise a PR from your own fork?

@vanuatoo
Copy link
Contributor

Done
#129

@tomjenkinson
Copy link
Contributor Author

Thanks for the contribution! I will close this but if I was wrong to do so and there is further work expected please respond

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants