Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate the Pebble extension #234

Closed
chkal opened this issue Nov 15, 2020 · 4 comments · Fixed by #258
Closed

Reactivate the Pebble extension #234

chkal opened this issue Nov 15, 2020 · 4 comments · Fixed by #258
Assignees
Milestone

Comments

@chkal
Copy link
Contributor

chkal commented Nov 15, 2020

This extension is currently disabled, because the underlying template engine doesn't support the new jakarta.* package namespace yet. We have to:

  • Wait for a new version of the template engine and update our dependencies.
  • Reactivate the corresponding tests in our testsuite (currently disabled via @Ignore)

As a last resort we may also decide to remove the extension.

Please note that I assigned this issue to the 2.0.0 milestone. However, the issue should NOT be a blocker for the 2.0.0 release.

@chkal chkal added this to the 2.0.0 milestone Nov 15, 2020
@chkal
Copy link
Contributor Author

chkal commented Nov 15, 2020

I created a corresponding issue in the upstream project: PebbleTemplates/pebble#548

@chkal chkal added the wait:dependency Waiting for a third party dependency to be enhanced or updated label Nov 15, 2020
@chkal
Copy link
Contributor Author

chkal commented Nov 18, 2020

Upstream pull request: PebbleTemplates/pebble#549

@chkal
Copy link
Contributor Author

chkal commented Nov 18, 2020

Upstream issue fixed. So we just have to wait for the next release, so we can use the new Servlet5Loader. Currently, the version in the pom.xml is set to 3.1.5-SNAPSHOT. So 3.1.5 should work.

@erdlet
Copy link
Member

erdlet commented Apr 24, 2021

3.1.5 was released in february, so we can update and test the extension now.

@erdlet erdlet removed the wait:dependency Waiting for a third party dependency to be enhanced or updated label Apr 24, 2021
@erdlet erdlet modified the milestones: 2.0.0, 3.0.0 Apr 24, 2021
@erdlet erdlet self-assigned this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants