Drop support for CURRENT_COMPONENT CURRENT_COMPOSITE_COMPONENT in FacesContext attrs map

[ren-zhijun-oracle]

The JSF specification contains the following:

/**

• The key to which the

• UIComponent currently being processed will be

• associated with within the {@link FacesContext} attributes map.

  
  *
  • @see javax.faces.context.FacesContext#getAttributes()
  • @SInCE 2.0
    */
    public static final String CURRENT_COMPONENT =
    "javax.faces.component.CURRENT_COMPONENT";

  /**

  • The key to which the

  • composite UIComponent currently being
  • processed will be associated with within the {@link FacesContext}

• attributes map.

  
  *

• @see javax.faces.context.FacesContext#getAttributes()
  *

• @SInCE 2.0
  */
  public static final String CURRENT_COMPOSITE_COMPONENT =
  "javax.faces.component.CURRENT_COMPOSITE_COMPONENT";

The guarantee that the current and current composite components are
available through FacesContext.getAttributes() doesn't seem right for
several reasons:

1. It isn't useful. The static methods
   UIComponent.getCurrentComponent() and
   UIComponent.getCurrentCompositeComponent() are more convenient and typesafe.
2. It is dangerous. If the values of these attributes is set, the
   current stack will be messed up
3. When we aren't using the particular space-inefficient implementation
   the JSF RI currently uses, maintaining these attributes just in case a
   developer tries to request them is a waste

Environment

Operating System: All
Platform: All

Affected Versions

[2.0.2]

[ren-zhijun-oracle]

@javaserverfaces Commented
Reported by @edburns

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
performance

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
enhancement, not defect

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
add adf keyword

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
triage

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
Take these.

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
target 2.1

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
These will all be done for GF 3.1 M6 at the latest!

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
adf issues targeted for GlassFish 3.1 M5

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
Target these for M3

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
Target M4

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=868

[ren-zhijun-oracle]

@javaserverfaces Commented
Marked as incomplete on Monday, July 19th 2010, 9:13:12 am

[ren-zhijun-oracle]

@javaserverfaces Commented
@manfredriem said:
Closing out resolved issue

[ren-zhijun-oracle]

@javaserverfaces Commented
This issue was imported from java.net JIRA JAVASERVERFACES-1623

[ren-zhijun-oracle]

• Issue Imported From: https://github.com/javaserverfaces/mojarra/issues/1627
• Original Issue Raised By:@javaserverfaces
• Original Issue Assigned To: @edburns
• Original Issue Closed By:@javaserverfaces