Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in documentation about h:message(s) tooltip="true" #2164

Closed
ren-zhijun-oracle opened this issue Aug 4, 2011 · 15 comments
Closed

Error in documentation about h:message(s) tooltip="true" #2164

ren-zhijun-oracle opened this issue Aug 4, 2011 · 15 comments
Assignees

Comments

@ren-zhijun-oracle
Copy link
Contributor

http://download.oracle.com/javaee/6/javaserverfaces/2.1/docs/vdldocs/facelets/h/message.html

The tooltip attribute description says

Flag indicating whether the detail portion of the message should be displayed as a tooltip.

So, I'd expect that the summary is displayed as real message and that detail is displayed as tooltip. However that didn't work as expected.

The "rendering" part of the tag introduction says

If the UIMessage has a "tooltip" attribute with the value of "true", and the UIMessage has "showSummary" and "showDetail" properties with the value "true", if we haven't already written out the "span", output the "summary" as the value of the "title" attribute on the "span". If we haven't already written out a "title" attribute, and "showSummary" is true, output the summary. If "showDetail" is true, output the detail. Close out the span if necessary.

So, it's saying that it only works when showDetail="true" is added as well. That is indeed what is happening. But it is displaying the detail as real message and the summary as tooltip.

Who's right? I personally prefer the original tooltip attribute description as it makes more sense. A tooltip is by nature supposed to present more detailed information.

Environment

Mojarra 2.1.2

Affected Versions

[2.1.1]

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
Reported by @BalusC

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
Was assigned to rogerk

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
rogerk said:
Thanks - I'll take a look.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
rogerk said:
Hmm... yes it does seem like the rendering details (instructions) are not consistent with the tooltip attribute description..

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
rogerk said:
Ok - the default value for showDetail is "true".
So...
I'll look into clarifying/changing the renderkit docs to use the detail for the tooltip.
So, for example, if you have something like:

<h:message for="foo" showSummary="true" tooltip="true"/>

Assuming there is a detail message, it will use that as the tooltip..

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
rogerk said:
Changes. The cases are outlined in the change file in:

jsf-ri/systest/web/messages.xhtml
jsf-ri/systest/web/message05.xhtml

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
File: changebundle-2160.txt
Attached By: rogerk

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
rogerk said:
Revised change bundle.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
File: changebundle-2160-revised.txt
Attached By: rogerk

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
@edburns said:
r=edburns. Very nice change bundle. Is there a linked spec issue? Please make it so when we grep the svn logs for the string "SPEC" this commit shows up in any case.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
rogerk said:
Checked into trunk:
Sending jsf-api/doc/standard-html-renderkit-base.xml
Sending jsf-api/doc/standard-html-renderkit.xml
Sending jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic/MessageRenderer.java
Sending jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic/MessagesRenderer.java
Sending jsf-ri/systest/src/com/sun/faces/render/MessageRenderTestCase.java
Adding jsf-ri/systest/src/com/sun/faces/render/MessagesRenderTestCase.java
Adding jsf-ri/systest/src/com/sun/faces/systest/MessageBean.java
Adding jsf-ri/systest/web/message05.xhtml
Adding jsf-ri/systest/web/messages.xhtml
Sending jsf-ri/systest/web/regexp/standard/messages02.txt
Sending jsf-ri/test/com/sun/faces/renderkit/html_basic/TestRenderers_2.java
Transmitting file data ...........
Committed revision 9247.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
rogerk said:
The spec issue for this is:
http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1030

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
Marked as fixed on Monday, February 20th 2012, 9:25:50 am

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
This issue was imported from java.net JIRA JAVASERVERFACES-2160

@ren-zhijun-oracle
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants