Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect-param are ignored #3403

Closed
ren-zhijun-oracle opened this issue Aug 28, 2014 · 13 comments
Closed

redirect-param are ignored #3403

ren-zhijun-oracle opened this issue Aug 28, 2014 · 13 comments

Comments

@ren-zhijun-oracle
Copy link
Contributor

Following issue JAVASERVERFACES_SPEC_PUBLIC-698, the view-param element in the faces-config.xml file was renamed to redirect-param in the spec, and the xsd updated accordingly.

On Mojarra 2.2.7, the element redirect-param is ignored and the element view-param is correctly taken into account to generate a parameter in the redirection.

Environment

Windows 7
Glassfish 4.1 SNAPSHOT (b13)
jdk8

Affected Versions

[2.2.7]

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
Reported by jolangloys

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
@manfredriem said:
Are you saying the runtime is not reacting on a redirect-param? If so can you please send a reproducer to issues@javaserverfaces.java.net? Thanks!

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
jolangloys said:
Hello,

Yes, the runtime is not reacting to a redirect-param.
I sent you the reproducer.

Thanks for your help.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
File: JSF-3399.war
Attached By: @manfredriem

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
@edburns said:
Thanks for the reproducer.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
jolangloys said:
Hello,

The problem might come from the NavigationConfigProcessor class :

**com.sun.faces.config.processor.NavigationConfigProcessor**    /**
     * <p>/faces-confg/navigation-rule/navigation-case/redirect/view-param</p>
     */
    private static final String VIEW_PARAM = "view-param";

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
@manfredriem said:
As you already stated you can use the deprecated view-param element. We will fix the implementation to correctly address the redirect-param element.

Thanks!

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
File: changebundle.txt
Attached By: @manfredriem

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
File: newfiles.zip
Attached By: @manfredriem

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
@manfredriem said:
Applied to 2.3 trunk,

svn commit -m "Fixes https://java.net/jira/browse/JAVASERVERFACES-3399, make sure redirect-param is supported."
Sending jsf-ri/src/main/java/com/sun/faces/config/processor/NavigationConfigProcessor.java
Adding test/servlet30/facelets/core/src/main/java/com/sun/faces/test/servlet30/facelets/core/ViewParamRedirectBean.java
Sending test/servlet30/facelets/core/src/main/webapp/WEB-INF/faces-config.xml
Adding test/servlet30/facelets/core/src/main/webapp/viewParamRedirect1.xhtml
Adding test/servlet30/facelets/core/src/main/webapp/viewParamRedirect2.xhtml
Adding test/servlet30/facelets/core/src/test/java/com/sun/faces/test/servlet30/facelets/core/Issue3399IT.java
Transmitting file data ......
Committed revision 13618.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
Marked as fixed on Tuesday, September 2nd 2014, 9:41:53 am

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
This issue was imported from java.net JIRA JAVASERVERFACES-3399

@ren-zhijun-oracle
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant