Skip to content

Commit

Permalink
Update to explore an agnostic nameclature on tck mappger
Browse files Browse the repository at this point in the history 
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
  • Loading branch information
@otaviojava
otaviojava committed Jul 4, 2022
1 parent a748dc5 commit 84cae9a
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 22 deletions.
60 changes: 43 additions & 17 deletions .../src/main/java/jakarta/nosql/tck/mapping/column/InheritanceColumnEntityConverterTest.java
View file
Expand Up @@ -16,6 +16,7 @@
package jakarta.nosql.tck.mapping.column;

import jakarta.nosql.column.ColumnEntity;
import jakarta.nosql.mapping.MappingException;
import jakarta.nosql.mapping.column.ColumnEntityConverter;
import jakarta.nosql.tck.entities.inheritance.EmailNotification;
import jakarta.nosql.tck.entities.inheritance.LargeProject;
Expand Down Expand Up @@ -44,7 +45,7 @@ public class InheritanceColumnEntityConverterTest {
@Test
public void shouldConvertProjectToSmallProject() {
ColumnEntity entity = ColumnEntity.of("Project");
entity.add("name", "Small Project");
entity.add("_id", "Small Project");
entity.add("investor", "Otavio Santana");
entity.add("size", "Small");
Project project = this.converter.toEntity(entity);
Expand All @@ -57,7 +58,7 @@ public void shouldConvertProjectToSmallProject() {
@Test
public void shouldConvertProjectToLargeProject() {
ColumnEntity entity = ColumnEntity.of("Project");
entity.add("name", "Large Project");
entity.add("_id", "Large Project");
entity.add("budget", BigDecimal.TEN);
entity.add("size", "Large");
Project project = this.converter.toEntity(entity);
Expand All @@ -68,29 +69,29 @@ public void shouldConvertProjectToLargeProject() {
}

@Test
public void shouldConvertLargeProjectToColumnEntity() {
public void shouldConvertLargeProjectToCommunicationEntity() {
LargeProject project = new LargeProject();
project.setName("Large Project");
project.setBudget(BigDecimal.TEN);
ColumnEntity entity = this.converter.toColumn(project);
assertNotNull(entity);
assertEquals("Project", entity.getName());
assertEquals(project.getName(), entity.find("name", String.class).get());
assertEquals(project.getName(), entity.find("_id", String.class).get());
assertEquals(project.getBudget(), entity.find("budget", BigDecimal.class).get());
assertEquals("Large", entity.find("type", String.class).get());
assertEquals("Large", entity.find("size", String.class).get());
}

@Test
public void shouldConvertSmallProjectToColumnEntity() {
public void shouldConvertSmallProjectToCommunicationEntity() {
SmallProject project = new SmallProject();
project.setName("Small Project");
project.setInvestor("Otavio Santana");
ColumnEntity entity = this.converter.toColumn(project);
assertNotNull(entity);
assertEquals("Project", entity.getName());
assertEquals(project.getName(), entity.find("name", String.class).get());
assertEquals(project.getName(), entity.find("_id", String.class).get());
assertEquals(project.getInvestor(), entity.find("investor", String.class).get());
assertEquals("Small", entity.find("type", String.class).get());
assertEquals("Small", entity.find("size", String.class).get());
}

@Test
Expand All @@ -107,8 +108,8 @@ public void shouldConvertColumnEntityToSocialMedia(){
assertEquals("Social Media", notification.getName());
assertEquals("otaviojava", notification.getNickname());
assertEquals(date, notification.getCreatedOn());

}

@Test
public void shouldConvertColumnEntityToSms(){
LocalDate date = LocalDate.now();
Expand All @@ -121,28 +122,28 @@ public void shouldConvertColumnEntityToSms(){
SmsNotification notification = this.converter.toEntity(entity);
Assertions.assertEquals(100L, notification.getId());
Assertions.assertEquals("SMS Notification", notification.getName());
Assertions.assertEquals("351987654123", notification.getPhone());
Assertions.assertEquals("+351987654123", notification.getPhone());
assertEquals(date, notification.getCreatedOn());
}

@Test
public void shouldConvertColumnEntityToEmail(){
LocalDate date = LocalDate.now();
ColumnEntity entity = ColumnEntity.of("Notification");
entity.add("_id", 100L);
entity.add("name", "Email Notification");
entity.add("phone", "otavio@otavio.test");
entity.add("email", "otavio@otavio.test");
entity.add("createdOn", date);
entity.add("type", "Email");
EmailNotification notification = this.converter.toEntity(entity);
Assertions.assertEquals(100L, notification.getId());
Assertions.assertEquals("SMS Notification", notification.getName());
Assertions.assertEquals("Email Notification", notification.getName());
Assertions.assertEquals("otavio@otavio.test", notification.getEmail());
assertEquals(date, notification.getCreatedOn());
}


@Test
public void shouldConvertSocialMediaToColumnEntity(){
public void shouldConvertSocialMediaToCommunicationEntity(){
SocialMediaNotification notification = new SocialMediaNotification();
notification.setId(100L);
notification.setName("Social Media");
Expand All @@ -156,8 +157,9 @@ public void shouldConvertSocialMediaToColumnEntity(){
assertEquals(notification.getNickname(), entity.find("nickname", String.class).get());
assertEquals(notification.getCreatedOn(), entity.find("createdOn", LocalDate.class).get());
}

@Test
public void shouldConvertSmsToColumnEntity(){
public void shouldConvertSmsToCommunicationEntity(){
SmsNotification notification = new SmsNotification();
notification.setId(100L);
notification.setName("SMS");
Expand All @@ -171,8 +173,9 @@ public void shouldConvertSmsToColumnEntity(){
assertEquals(notification.getPhone(), entity.find("phone", String.class).get());
assertEquals(notification.getCreatedOn(), entity.find("createdOn", LocalDate.class).get());
}

@Test
public void shouldConvertEmailToColumnEntity(){
public void shouldConvertEmailToCommunicationEntity(){
EmailNotification notification = new EmailNotification();
notification.setId(100L);
notification.setName("Email Media");
Expand All @@ -183,7 +186,30 @@ public void shouldConvertEmailToColumnEntity(){
assertEquals("Notification", entity.getName());
assertEquals(notification.getId(), entity.find("_id", Long.class).get());
assertEquals(notification.getName(), entity.find("name", String.class).get());
assertEquals(notification.getEmail(), entity.find("phone", String.class).get());
assertEquals(notification.getEmail(), entity.find("email", String.class).get());
assertEquals(notification.getCreatedOn(), entity.find("createdOn", LocalDate.class).get());
}

@Test
public void shouldReturnErrorWhenConvertMissingColumn(){
LocalDate date = LocalDate.now();
ColumnEntity entity = ColumnEntity.of("Notification");
entity.add("_id", 100L);
entity.add("name", "SMS Notification");
entity.add("phone", "+351987654123");
entity.add("createdOn", date);
Assertions.assertThrows(MappingException.class, ()-> this.converter.toEntity(entity));
}

@Test
public void shouldReturnErrorWhenMismatchField() {
LocalDate date = LocalDate.now();
ColumnEntity entity = ColumnEntity.of("Notification");
entity.add("_id", 100L);
entity.add("name", "Email Notification");
entity.add("email", "otavio@otavio.test");
entity.add("createdOn", date);
entity.add("type", "Wrong");
Assertions.assertThrows(MappingException.class, ()-> this.converter.toEntity(entity));
}
}
10 changes: 5 additions & 5 deletions .../main/java/jakarta/nosql/tck/mapping/document/InheritanceDocumentEntityConverterTest.java
View file
Expand Up @@ -68,7 +68,7 @@ public void shouldConvertProjectToLargeProject() {
}

@Test
public void shouldConvertLargeProjectToDocumentEntity() {
public void shouldConvertLargeProjectToCommunicationEntity() {
LargeProject project = new LargeProject();
project.setName("Large Project");
project.setBudget(BigDecimal.TEN);
Expand All @@ -81,7 +81,7 @@ public void shouldConvertLargeProjectToDocumentEntity() {
}

@Test
public void shouldConvertSmallProjectToDocumentEntity() {
public void shouldConvertSmallProjectToCommunicationEntity() {
SmallProject project = new SmallProject();
project.setName("Small Project");
project.setInvestor("Otavio Santana");
Expand Down Expand Up @@ -142,7 +142,7 @@ public void shouldConvertDocumentEntityToEmail(){
}

@Test
public void shouldConvertSocialMediaToDocumentEntity(){
public void shouldConvertSocialMediaToCommunicationEntity(){
SocialMediaNotification notification = new SocialMediaNotification();
notification.setId(100L);
notification.setName("Social Media");
Expand All @@ -158,7 +158,7 @@ public void shouldConvertSocialMediaToDocumentEntity(){
}

@Test
public void shouldConvertSmsToDocumentEntity(){
public void shouldConvertSmsToCommunicationEntity(){
SmsNotification notification = new SmsNotification();
notification.setId(100L);
notification.setName("SMS");
Expand All @@ -174,7 +174,7 @@ public void shouldConvertSmsToDocumentEntity(){
}

@Test
public void shouldConvertEmailToDocumentEntity(){
public void shouldConvertEmailToCommunicationEntity(){
EmailNotification notification = new EmailNotification();
notification.setId(100L);
notification.setName("Email Media");
Expand Down

0 comments on commit 84cae9a

Please sign in to comment.