New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the Jakarta NoSQL only for High level API #154
Conversation
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the DatabaseType removed?
Is there another way to tell which DB type you're using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crippling and disabling much of the API without a proper replacement is not a good approach.
Why wasn't most of it parked e.g. in the https://github.com/JNOSQL orga instead of deleting it all?
Beside a significant API reduction must go via a Release Review by the Spec Committee first.
@keilw those are a good point, I'll move it to JNoQL and show the full show later next week. |
@otaviojava Please wait till approached by @ivargrimstad or another mentor/Spec Committee Member. While it may not affect end users/developers using the API removing all those "SPIs" and stuffing them into the only compatible implementation could have a negative impact on other possible implementors, which is why those members should get a chance to review the proposed changes first. |
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Yes that is the next step. Ps: the release review happened through a milestone release, not a PR. And we have one year to give progress:
Reference: |
@otaviojava All of these were always done without a review, JNoSQL had the last release review on May 15th, 2019: https://projects.eclipse.org/projects/technology.jnosql
That means if you did not do one in one year it may be requested by the spec committee, but you're supposed to request a review from the project side, if you publish a milestone, especially with such a massive change. Either way, Config scheduled what seems like a progress review in May, so we should probably do the same here. |
A couple of comments:
|
Furthermore, @keilw, take a look at here: |
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
This PR reduces the Jakarta NoSQL scope for high-level abstraction. It will make it easier to have more implementation.
To Eclipse JNoSQL users, it won't impact anything once it goes to JNoSQL implementation.
Changes
Ref: #153