JMSRA ActivationSpec property endpointPoolResizeTimeout should allow zero value

[glassfishrobot]

This fix is needed as part of the solution to GLASSFISH-4629

• [UB]Some wrong MDB warnings at startup when attribute value is 0 glassfish#4629

Currently, com.sun.messaging.jms.ra.ActivationSpec.setEndpointPoolResizeTimeout(int endpointPoolResizeTimeout) will throw an IllegalArgumentException if a value of 0 is supplied, meaning "infinite timeout".

JMSRA does not use this value. The current behaviour is that endpoints do not timeout, so in fact a value of 0 corresponds to the current behaviour but is not allowed.

Affected Versions

[4.5]

[glassfishrobot]

@glassfishrobot Commented
Reported by @nigeldeakin

[glassfishrobot]

@glassfishrobot Commented
@nigeldeakin said:
Now fixed in MQ 4.6

C:\mq\MQ4.6>hg diff src\share\java\com\sun\messaging\jms\ra\ActivationSpec.java
diff -r 2abfe80d30b1 src/share/java/com/sun/messaging/jms/ra/ActivationSpec.java

--- a/src/share/java/com/sun/messaging/jms/ra/ActivationSpec.java       Tue Jun 21 13:46:22 2011 -0700
+++ b/src/share/java/com/sun/messaging/jms/ra/ActivationSpec.java       Tue Jun 28 10:00:49 2011 +0100
@@ -717,9 +717,10 @@
     setEndpointPoolResizeTimeout(int endpointPoolResizeTimeout)
     {
         _loggerIM.entering(_className, "setEndpointPoolResizeTimeout()", Integer.toString(endpointPoolResizeTimeout));
-        if (endpointPoolResizeTimeout < 1) {
+        // MQ-103 Allow a value of 0, which means no timeout
+        if (endpointPoolResizeTimeout < 0) {
             IllegalArgumentException iae = new IllegalArgumentException(_lgrMID_EXC+"setEndpointPoolResizeTimeout:"+
-    "Value must be greater than 0:"+
+    "Value must not be negative:"+
     "Invalid value="+endpointPoolResizeTimeout);
             _loggerIM.warning(iae.getMessage());
             _loggerIM.throwing(_className, "setEndpointPoolResizeTimeout()", iae);
}}

[glassfishrobot]

@glassfishrobot Commented
saradak said:
The bug is not fixed. I am still seeing the following error when trying to set endpointPoolResizeTimeout on activationspec.

Mar 29, 2013 5:14:20 PM com.sun.messaging.jms.ra.ActivationSpec setEndpointPoolResizeTimeout
WARNING: MQJMSRA_AS4001: setEndpointPoolResizeTimeout:Value must be greater than 0:Invalid value=0
java.lang.IllegalArgumentException: MQJMSRA_AS4001: setEndpointPoolResizeTimeout:Value must be greater than 0:Invalid
value=0
at com.sun.messaging.jms.ra.ActivationSpec.setEndpointPoolResizeTimeout(ActivationSpec.java:733)
at test.jmsclient.ra.SerialMessageDeliveryTest001.test(SerialMessageDeliveryTest001.java:81)
at test.jmsclient.ra.SerialMessageDeliveryTest001.main(SerialMessageDeliveryTest001.java:47)

[glassfishrobot]

@glassfishrobot Commented
This issue was imported from java.net JIRA MQ-103

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/openmq/issues/103
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @edbratt

[pzygielo]

Hi @edbratt - could you please check - and if it was fixed - let's close this issue, if it wasn't fixed - let's unbind this from 5.0 milestone.