Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servlet api issue 175 add cookie set attribute v3 #401

Merged
merged 15 commits into from May 17, 2021
Merged

Servlet api issue 175 add cookie set attribute v3 #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5bb8145
Add Cookie#setAttribute
BalusC Apr 26, 2021
6efffc6
Merge branch 'master' of git@github.com:BalusC/servlet-api.git
BalusC Apr 26, 2021
5fb98a5
Skip null value from check for reserved token
BalusC Apr 26, 2021
3493d02
Alternative approach to cookie attribute handling
BalusC May 2, 2021
d5ec45f
Make sure path is referenced via constant
BalusC May 2, 2021
5d98584
In hindsight, token check doesn't need to be performed on value
BalusC May 2, 2021
bda9697
Merge remote-tracking branch 'origin/servlet-api-issue-175_add-cookie…
BalusC May 2, 2021
0c58ccd
Match casing with spec; mapping is case insensitive anyway
BalusC May 2, 2021
597c87c
Optimized Cookie to lazily create attribute map
gregw May 3, 2021
6201792
Added junit test
gregw May 4, 2021
5754e4e
Updates from review
gregw May 4, 2021
f407bb4
Fixed quote
gregw May 4, 2021
9e58b99
surefire plugin
gregw May 4, 2021
2a80335
Updates from review
gregw May 4, 2021
187cc61
Updates from review
gregw May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 29 additions & 1 deletion api/pom.xml
View file
Open in desktop
Expand Up @@ -85,6 +85,27 @@
<url>https://github.com/eclipse-ee4j/servlet-api/issues</url>
</issueManagement>

<dependencies>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>5.7.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<version>5.7.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest</artifactId>
<version>2.2</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move these to a section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the versions to properties?

<scope>test</scope>
</dependency>
</dependencies>

<build>
<resources>
<resource>
Expand Down Expand Up @@ -148,7 +169,14 @@
<compilerArgument>-Xlint:all</compilerArgument>
</configuration>
</plugin>


<!-- Execute unit tests -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.0.0-M5</version>
</plugin>

<!-- Checks copyright / license headers -->
<plugin>
<groupId>org.glassfish.copyright</groupId>
Expand Down