-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire native splash loading #19
Comments
I'd love to remove it. Early window system initialization in the launcher and splash screen hand-off to SWT require some messy code. Both the launcher and SWT could be significantly simplified if we remove the native splash screen. I know that non-OSGI SWT app startup is fast enough to implement the splash in Java, but I'm not sure about the platform. |
I'd love to get rid the native launcher altogether and replace it by simple sh/bat scripts. If it isn't going to display the splash natively what is the point of all the complexity in building and running a native launcher? I suppose some native branding? |
@tjwatson Good UX on Windows and macOS requires a native executable. It's not just branding, though branding is important. Various system and 3rd party services (for example, antivirus and firewall) identify running programs by their executable. Cutting the launcher down to the bare minimum would be great. But I suspect that consumers depend on gazillion options being available in eclipse.ini. |
Getting rid of the launcher entirely seems super disruptive to anyone building products currently... |
OK OK, just wishful thinking. |
On this point, other products I work on that use a script to launch java easily parse something like an eclipse.ini to get things like JVM args to pass to an exec of java. |
@tjwatson sticking to splash for this bug seems to be enough ;) That said, is you don't like much having native launcher in Equinox and feel it's more part of Eclipse Platform to maintain them, it could probably be worth moving it to eclipse-platform project. |
Native launcher takes care of opening files on Gtk. Can it be done differently? Sure, it just hasn't been until now. Regarding splash screen itself - I like the idea and having simpler natives is always better. |
Lets bring this to the next PMC meeting to decide. Afterwards we can start the changes, if the PMC agrees. |
The PMC decided that we want to remove the native splash support. To avoid late regressions, we should do this early 4.25. RCP and IDEs will still be able to show the splash via the Java spash handler. 3.x apps can specify this via the product and e4 apps can use the life cycle hook. |
@nnemkin Are you working on this one? As I've been looking into adding Gtk 4.x support, not dealing with image loading would simplify it. |
This issue has been inactive for 180 days and is therefore labeled as stale. |
This is a follow-up from a discussion about the usefullness of the native splash handler we had in the PMC call.
As the Java code which shows the splash is executed relatively fast, it was indicated that we could stop loading the bmp at startup time and leave the loading of a potential splash to the Java splash handler.
WDYT @tjwatson @nnemkin @akurtakov
The text was updated successfully, but these errors were encountered: