[IconExe] should support BI_BITFIELDS

[laeubi]

Currently only bitmaps with either BI_RLE8 or BI_RLE4 are supported.
32 bit BMPs are also allowed to have a value of BI_BITFIELDS, it seems GIMP produces them when res >=256px so the replacement currently fails with

[IconExe] Error - 1 original icon(s) not replaced in eclipse.exe:
- 256x256, 32 bits, 270376 byte(s) @ 144256

I'm not very familiar with the BMP fileformat so I can't provide a fix yet.

Migrated Bug 552627 ...

[iloveeclipse]

You probably want it to report for SWT, where we load image data etc?
Or do you know it's in some particular PDE code?

[laeubi]

Sorry I wanted to link the class affected:

https://github.com/eclipse-equinox/p2/blob/master/bundles/org.eclipse.equinox.p2.publisher.eclipse/src/org/eclipse/pde/internal/swt/tools/IconExe.java

this case some copy code from SWT :-\