Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edge routing in GLSP projection view #275

Merged
merged 1 commit into from Aug 11, 2023
Merged

Conversation

planger
Copy link
Member

@planger planger commented Aug 10, 2023

We should compute all routes at once in order to enable edge route postprocessors and with that also the intersection detection. When only computing one route after the other we cannot detect intersections and thus don't render gaps on edge intersections.

Fixes eclipse-glsp/glsp#1084

We should compute all routes at once in order to enable edge route
postprocessors and with that also the intersection detection. When only
computing one route after the other we cannot detect intersections and
thus don't render gaps on edge intersections.

Fixes eclipse-glsp/glsp#1084
@planger planger requested a review from tortmayr August 10, 2023 16:34
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and edge intersection detection works again as expected!

@planger planger merged commit 7a47c01 into master Aug 11, 2023
6 checks passed
@planger planger deleted the planger/issues/1084 branch August 11, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow example edges gaps on intersections no longer rendered
2 participants