Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pom.xml modelVersion from "4.0" to "4.0.0" #461

Closed
fransvanbuul opened this issue Oct 11, 2022 · 6 comments
Closed

Change pom.xml modelVersion from "4.0" to "4.0.0" #461

fransvanbuul opened this issue Oct 11, 2022 · 6 comments

Comments

@fransvanbuul
Copy link

In the JDT Core published pom, the "modelVersion" is set to "4.0". As per the Maven docs, this should be "4.0.0".

This doesn't really break anything, but it creates an error message everytime my (otherwise pristine) Gradle build runs:

Errors occurred while build effective model from C:\Users\xxxxx\.gradle\caches\modules-2\files-2.1\org.eclipse.jdt\org.eclipse.jdt.core\3.31.0\6940726f829e8aa123374a4ccac8225f5dd0a3c0\org.eclipse.jdt.core-3.31.0.pom: 'modelVersion' must be one of [4.0.0] but is '4.0'. in org.eclipse.jdt:org.eclipse.jdt.core:3.31.0

Could you fix this?
Thanks in advance!
Frans

@xamde
Copy link

xamde commented Jan 12, 2023

I've run into the same problem, but for me it is breaking a Maven build

@xamde
Copy link

xamde commented Jan 12, 2023

The current version in git is already fixed, so we are just waiting for the next release

@Lucas3oo
Copy link

Seems that many of the eclipse artefacts have this issue.
E.g https://repo1.maven.org/maven2/org/eclipse/platform/org.eclipse.core.expressions/3.8.200/org.eclipse.core.expressions-3.8.200.pom is also using "4.0" instead of "4.0.0" as model version so we still get a similar warning.

@srikanth-sankaran
Copy link
Contributor

@iloveeclipse @jarthana - what is the status/validity of this ?? Looks like a trivial fix if problem is real. Sorry I am clueless so don't want to work on it myself

@iloveeclipse
Copy link
Member

I'm not maven expert, so no idea.
@akurtakov ?

@akurtakov
Copy link
Contributor

FYI deployed poms are not the poms used during development but rather a generated ones after the release (https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/eclipse.platform.releng/publish-to-maven-central) and these hand crafter pom files were not quite good in the past. Latest deployed pom https://repo1.maven.org/maven2/org/eclipse/jdt/org.eclipse.jdt.core/3.36.0/org.eclipse.jdt.core-3.36.0.pom uses 4.0.0 so the tool seems to generate proper modelVersion now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants