Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate partial results for workspace/symbol request #1712

Open
rgrunber opened this issue Mar 31, 2021 · 1 comment
Open

Investigate partial results for workspace/symbol request #1712

rgrunber opened this issue Mar 31, 2021 · 1 comment

Comments

@rgrunber
Copy link
Contributor

https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workspace_symbol seems to support partial results and with changes like #1688 coming eventually, it might be great to have this.

On the JDT-LS side WorkspaceSymbolHandler aggregates the results into a list that is accessible from the callback methods that are triggered for every new match. We don't have to wait for all results.

@rgrunber
Copy link
Contributor Author

The LSP spec supports this, but it would be good to know which clients do. For example, looking at microsoft/vscode#105870 , there is no support, as the workspace/symbol request currently sends a null partialResultToken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants