Only return jdt:// urls if clients support it

[GordianDziwis]

The language server returns links based on the jdt protocol instead a filepath jdt://contents/slf4j-api-1.7.10.jar/org.slf4j/ILoggerFactory.class?=linkedgeodata-core/%5C/home%5C/some%5C/.m2%5C/repository%5C/org%5C/slf4j%5C/slf4j-api%5C/1.7.10%5C/slf4j-api-1.7.10.jar%3Corg.slf4j%28ILoggerFactory.class#38

Neovim can not handle those, is it possible to configure the server in a way, that a filepath is returned?

See Uris like jdt://... not supported · Issue #392 · autozimu/LanguageClient-neovim

[fbricon]

Not really. Those links are for class files inside jar files. So returning a file path makes no sense.
The best thing I can think of is add a capability flag, sent from the client, which, if set to false, would not return those jdt:// URIs at all, effectively killing the navigation to class files

[GordianDziwis]

And with this function it would be possible to retrieve the source.
But this is an extension to LSP and java specific?

[fbricon]

yes, but it needs the client to send jdt based uris

[fbricon]

All search scopes need to be changed so that

int scope = IJavaSearchScope.SOURCES;
if (classFileContentSupported) {
	scope |= IJavaSearchScope.APPLICATION_LIBRARIES | IJavaSearchScope.SYSTEM_LIBRARIES;
}

[GordianDziwis]

It is possible to unpack the dependencies with maven:

mvn dependency:unpack-dependencies
  -Dclassifier=sources
  -Dmdep.failOnMissingClassifierArtifact=false

Could a client use these for browsing the sources?

[fbricon]

That won't work. The server maps the binary jars to their matching source jars automatically. There's no way to map sources to a different folder server-side. Even if we added a way to do it, neovim would still have to do some custom development to call that new mechanism. So however we do it, it won't work OOTB for any client.

[fbricon]

FTR, clients will need to advertise their support by passing extendedClientCapabilities.classFileContentsSupport=true in initializationOptions, as in

    "initializationOptions": {
        "bundles": [...],
        "workspaceFolders": [...],
        "settings": {...},
        "extendedClientCapabilities": {
            "classFileContentsSupport": true
        }
    },

cc @brookhong