Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should pick tomcat 10 if Jakarta EE provided api is used in the dependencies #1324

Closed
sunix opened this issue Mar 3, 2022 · 1 comment · Fixed by #1385
Closed

should pick tomcat 10 if Jakarta EE provided api is used in the dependencies #1324

sunix opened this issue Mar 3, 2022 · 1 comment · Fixed by #1385
Assignees
Labels
bug Something isn't working demoable Issues which can be demoed during the Sprint review meeting enhancement New feature or request
Milestone

Comments

@sunix
Copy link
Member

sunix commented Mar 3, 2022

Description

For webapp using jakarta ee, tomcat 10 should be used instead of 9

  <dependencies>
    <!-- Add servlet dependencies -->
    <dependency>
      <groupId>jakarta.servlet</groupId>
      <artifactId>jakarta.servlet-api</artifactId>
      <version>5.0.0</version>
      <scope>provided</scope>
    </dependency>
    <!-- Add jsp dependencies -->
    <dependency>
      <groupId>jakarta.servlet.jsp</groupId>
      <artifactId>jakarta.servlet.jsp-api</artifactId>
      <version>3.0.0</version>
      <scope>provided</scope>
    </dependency>
import jakarta.servlet.ServletException;
import jakarta.servlet.http.HttpServlet;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;

Info

@manusa
Copy link
Member

manusa commented Mar 4, 2022

We need to create a base Tomcat10 image.

Tomcat 10 should be used in all cases or if we want to keep Tomcat9 too, implement a new Handler for the new conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working demoable Issues which can be demoed during the Sprint review meeting enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants