We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
JKube Kit
Related to #1273
馃毀 Requires #1995 to get merged first
We changed JKubeAnnotations to have jkube.eclipse.org prefix instead of jkube.io. But there are still some places where jkube.io is still getting used. It's not in form of annotations, but in form of volume mount points: https://github.com/eclipse/jkube/blob/8db1fe14e9dfe7321bd00d68fd508f4e82a61822/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/AutoTLSEnricher.java#L55 https://github.com/eclipse/jkube/blob/8db1fe14e9dfe7321bd00d68fd508f4e82a61822/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/AutoTLSEnricher.java#L57
jkube.eclipse.org
jkube.io
We should update these to use jkube.eclipse.org instead.
Mount points should have jkube.eclipse.org in them instead of jkube.io
tlsSecretVolumeMountPoint
jksVolumeMountPoint
The text was updated successfully, but these errors were encountered:
Can't we just use jkube instead of a fully qualified domain name? Is there any specific reason to use such convention here?
jkube
Sorry, something went wrong.
No branches or pull requests
Component
JKube Kit
Task description
Description
Related to #1273
馃毀 Requires #1995 to get merged first
We changed JKubeAnnotations to have
jkube.eclipse.org
prefix instead ofjkube.io
. But there are still some places wherejkube.io
is still getting used. It's not in form of annotations, but in form of volume mount points:https://github.com/eclipse/jkube/blob/8db1fe14e9dfe7321bd00d68fd508f4e82a61822/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/AutoTLSEnricher.java#L55
https://github.com/eclipse/jkube/blob/8db1fe14e9dfe7321bd00d68fd508f4e82a61822/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/AutoTLSEnricher.java#L57
We should update these to use
jkube.eclipse.org
instead.Expected Behavior
Mount points should have
jkube.eclipse.org
in them instead ofjkube.io
Acceptance Criteria
tlsSecretVolumeMountPoint
andjksVolumeMountPoint
should have default values containing updated jkube prefixesjkube.eclipse.org
The text was updated successfully, but these errors were encountered: