Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AutoTLSEnricher's volume mount path locations to use updated jkube domains #2068

Open
3 tasks
rohanKanojia opened this issue Feb 23, 2023 · 1 comment
Open
3 tasks

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

Description

Related to #1273

馃毀 Requires #1995 to get merged first

We changed JKubeAnnotations to have jkube.eclipse.org prefix instead of jkube.io. But there are still some places where jkube.io is still getting used. It's not in form of annotations, but in form of volume mount points:
https://github.com/eclipse/jkube/blob/8db1fe14e9dfe7321bd00d68fd508f4e82a61822/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/AutoTLSEnricher.java#L55
https://github.com/eclipse/jkube/blob/8db1fe14e9dfe7321bd00d68fd508f4e82a61822/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/AutoTLSEnricher.java#L57

We should update these to use jkube.eclipse.org instead.

Expected Behavior

Mount points should have jkube.eclipse.org in them instead of jkube.io

Acceptance Criteria

  • AutoTLSEnricher tlsSecretVolumeMountPoint and jksVolumeMountPoint should have default values containing updated jkube prefixes jkube.eclipse.org
  • Users should be allowed to use older prefixes if they want
  • Tests should be updated to use new prefixes
@manusa
Copy link
Member

manusa commented Mar 7, 2023

Can't we just use jkube instead of a fully qualified domain name? Is there any specific reason to use such convention here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants