Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JKube tasks not executed with Gradle 8.2.1 #2299

Closed
sunix opened this issue Jul 21, 2023 · 6 comments · Fixed by #2321
Closed

JKube tasks not executed with Gradle 8.2.1 #2299

sunix opened this issue Jul 21, 2023 · 6 comments · Fixed by #2321
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sunix
Copy link
Member

sunix commented Jul 21, 2023

Describe the bug

It looks like JKube tasks are broken with Gradle 8.2.1.
Nothing is executed, and it is showing BUILD SUCCESSFUL

Eclipse JKube version

SNAPSHOT

Component

Kubernetes Gradle Plugin

Apache Maven version

None

Gradle version

other (please specify in additional context)

Steps to reproduce

  1. Go to quickstarts/gradle/webapp
  2. Use Gradle 8.2.1
    $ sdk use gradle 8.2.1
    Using gradle version 8.2.1 in this shell
    
  3. Run k8sBuild tasks
    $ gradle build k8sBuild 
    > Task :k8sBuild
    k8s: Building container image in Kubernetes mode
    Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
    You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
    For more on this, please refer to https://docs.gradle.org/8.2.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
    BUILD SUCCESSFUL in 2s
    3 actionable tasks: 3 executed
    
    

Expected behavior

The expected behaviour is what we have with 7.6.2:

  1. Go to quickstarts/gradle/webapp
  2. Use Gradle 7.6.2
    $ sdk use gradle 7.6.2
    Using gradle version 7.6.2 in this shell.
    
  3. Run k8sBuild tasks
    $ gradle build k8sBuild 
    > Task :k8sBuild
    k8s: Running generator webapp
    k8s: webapp: Using quay.io/jkube/jkube-tomcat:0.0.19 as base image for webapp
    k8s: webapp: HINT: Tomcat webapps dir is set to `webapps-javaee` by default for retrocompatibility. If your project is already JakartaEE compliant, set `jkube.generator.webapp.env` to `TOMCAT_WEBAPPS_DIR=webapps` for a faster startup.
    k8s: Building container image in Kubernetes mode
    k8s: [kubernetes/webapp:latest] "webapp": Created docker-build.tar in 63 milliseconds
    locking FileBasedConfig[/home/sunix/.config/jgit/config] failed after 5 retries
    > Task :k8sBuild
    k8s: [kubernetes/webapp:latest] "webapp": Built image sha256:740ba
    k8s: [kubernetes/webapp:latest] "webapp": Tag with latest
    BUILD SUCCESSFUL in 6s
    3 actionable tasks: 3 executed
    

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.25.3

Environment

Linux

Eclipse JKube Logs

No response

Sample Reproducer Project

/quickstarts/gradle/webapp

Additional context

No response

@sunix sunix added the bug Something isn't working label Jul 21, 2023
@asingh2295
Copy link
Contributor

asingh2295 commented Jul 21, 2023

@sunix Can you please assign this to me?

@rohanKanojia
Copy link
Member

rohanKanojia commented Jul 21, 2023

@asingh2295 : This is not a good first issue. Are you sure you want to work on this?

@asingh2295
Copy link
Contributor

asingh2295 commented Jul 21, 2023

Yes. I'm using gradle past one year. let me give a try.

@manusa
Copy link
Member

manusa commented Jul 24, 2023

We need to make sure that this is a problem with API compatibility. Please make sure to see if the issue is reproducible with former versions of Gradle 8 and also with both plugins. We want to rule out that this is a problem with API compatibility since this requires some extra work to make the APIs/dependencies available for a Maven project

@rohanKanojia
Copy link
Member

rohanKanojia commented Jul 27, 2023

While bumping gradle distribution version used in integration tests, I tried bumping it to v8.2.1. I observed that not all integration tests seem to be failing. Only these test cases are failing:

  • HelidonPropertiesIT
  • ProbesGroovyDSLIT
  • SmallRyeIT
  • VertxIT
  • SpringBootWithFragmentIT
  • SpringBootIT
  • HelidonIT
  • ConfigMapIT
  • SimpleIT
  • ResourceValidationIT
  • DependencyResourcesIT
  • KubernetesExtensionIT
  • OpenLibertyIT

Could this be something specific to the underlying framework?

@manusa manusa self-assigned this Aug 1, 2023
@manusa
Copy link
Member

manusa commented Aug 3, 2023

While bumping gradle distribution version used in integration tests, I tried bumping it to v8.2.1. I observed that not all integration tests seem to be failing. Only these test cases are failing:

  • HelidonPropertiesIT
  • ProbesGroovyDSLIT
  • SmallRyeIT
  • VertxIT
  • SpringBootWithFragmentIT
  • SpringBootIT
  • HelidonIT
  • ConfigMapIT
  • SimpleIT
  • ResourceValidationIT
  • DependencyResourcesIT
  • KubernetesExtensionIT
  • OpenLibertyIT

Could this be something specific to the underlying framework?

These failures might have more to do with the plugins applied in the sample projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants