Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SpringBootConfigurationHelper for Spring Boot 3.x #2324

Closed
1 task
rohanKanojia opened this issue Aug 8, 2023 · 1 comment · Fixed by #2325
Closed
1 task

Update SpringBootConfigurationHelper for Spring Boot 3.x #2324

rohanKanojia opened this issue Aug 8, 2023 · 1 comment · Fixed by #2325
Milestone

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

Description

Currently, SpringBootConfigurationHelper manages Spring Boot 1 and Spring Boot 2 property fields in form of string arrays like this:

https://github.com/eclipse/jkube/blob/ba86499db136707fe56debb87ce285f6078a8384/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/SpringBootConfigurationHelper.java#L38-L43

We need to update these to accommodate for Spring Boot 3 properties as well.

Expected Behavior

SpringBootConfigurationHelper should work for Spring Boot 3 as well

Acceptance Criteria

  • SpringBootConfigurationHelper works with Spring Boot 3
@rohanKanojia
Copy link
Member Author

rohanKanojia commented Aug 8, 2023

By adding Spring Boot Properties Migrator in spring boot 3 project with old properties configured, it seems to report that these properties would require changes:

Spring 2.x Spring 3.x Replacement
management.server.servlet.context-path management.server.base-path
server.servlet.path spring.mvc.servlet.path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants