You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This test should be changed because it's testing multiple things at once.
I didn't want to spend more time on this yet because it's out of the scope of the current changes.
Basically, none of these assertions belong here, since what they are checking is that the Mojo performs the correct JKubeConfiguration initialization, which has nothing to do with "shouldUpload".
We need a (multiple) test(s) here and in other mojos that verify(ies) shouldSetPushRegistry in JKubeConfiguration and shouldSetPullRegistry in JKubeConfiguration.
I didn't want to spend more time on this yet because it's out of the scope of the current changes.
Basically, none of these assertions belong here, since what they are checking is that the Mojo performs the correct JKubeConfiguration initialization, which has nothing to do with "shouldUpload".
We need a (multiple) test(s) here and in other mojos that verify(ies)
shouldSetPushRegistry in JKubeConfiguration
andshouldSetPullRegistry in JKubeConfiguration
.Originally posted by @manusa in #3067 (comment)
The text was updated successfully, but these errors were encountered: