Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tests for JKubeConfiguration initialization in Mojos (and Tasks) #3068

Open
manusa opened this issue May 17, 2024 · 0 comments
Open

Comments

@manusa
Copy link
Member

manusa commented May 17, 2024

          This test should be changed because it's testing multiple things at once.

I didn't want to spend more time on this yet because it's out of the scope of the current changes.
Basically, none of these assertions belong here, since what they are checking is that the Mojo performs the correct JKubeConfiguration initialization, which has nothing to do with "shouldUpload".
We need a (multiple) test(s) here and in other mojos that verify(ies) shouldSetPushRegistry in JKubeConfiguration and shouldSetPullRegistry in JKubeConfiguration.

Originally posted by @manusa in #3067 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant