Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should add prometheus.io/path #326

Closed
survivant opened this issue Jul 29, 2020 · 1 comment · Fixed by #360
Closed

should add prometheus.io/path #326

survivant opened this issue Jul 29, 2020 · 1 comment · Fixed by #360
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@survivant
Copy link
Contributor

you generate those labels

prometheus.io/port: "9779"
prometheus.io/scrape: "true"

could should add

prometheus.io/path: /metrics

to explicitly tell us where Prometheus will check for metrics

@rohanKanojia
Copy link
Member

@survivant : Thanks for sharing feedback for PrometheusEnricher. Would you like to submit a PR to fix this? Just need to do required changes here:

https://github.com/eclipse/jkube/blob/68ac53f4546610f05fbced4b75b49868a58556d7/jkube-kit/enricher/specific/src/main/java/org/eclipse/jkube/kit/enricher/specific/PrometheusEnricher.java#L44-L50

@manusa manusa added this to the 1.1.0 milestone Jul 30, 2020
@manusa manusa added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jul 30, 2020
@manusa manusa modified the milestones: 1.1.0, 1.0.0 Aug 3, 2020
@manusa manusa added this to Planned in Sprint #188 Aug 17, 2020
@manusa manusa moved this from Planned to In progress in Sprint #188 Aug 18, 2020
@manusa manusa self-assigned this Aug 18, 2020
@manusa manusa moved this from In progress to Review in Sprint #188 Aug 18, 2020
Sprint #188 automation moved this from Review to Done Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Sprint #188
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants