Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAP: Deal with notes view #11

Open
eclipsewebmaster opened this issue May 8, 2024 · 1 comment
Open

RAP: Deal with notes view #11

eclipsewebmaster opened this issue May 8, 2024 · 1 comment

Comments

@eclipsewebmaster
Copy link

| --- | --- |
| Bugzilla Link | 325206 |
| Status | NEW |
| Importance | P3 enhancement |
| Reported | Sep 14, 2010 04:37 EDT |
| Modified | Feb 20, 2023 15:34 EDT |
| Version | 1.1 |
| Blocks | 262603 |
| Reporter | Andrew Johnson |

Description

From bug 262603

  • Notes is currently completetly disabled as RAP does not support the Text
    Framework yet. We should either try to minimize the dependency to the Text
    Framework or put the notes view into a seperate bundle.

Another idea would be to display any existing notes file in read-only format.

@eclipsewebmaster
Copy link
Author

By Andrew Johnson on Feb 20, 2023 15:34

For RAP we could just use the Text control, which can be R/W.
We could use fragments, for example:

org.eclipse.mat.ui.swt
Require-Capability: osgi.identity;filter:=(&(osgi.identity=org.eclipse.swt)(type=osgi.bundle))

with the current implementation of NotesView.java (and the org.eclipse.io.views extension), and

org.eclipse.mat.ui.rap
Require-Capability: osgi.identity;filter:=(&(osgi.identity=org.eclipse.rap.rwt)(type=osgi.bundle))

with a cut down version (and the org.eclipse.ui.views extension).

Another way
Require-Capability: org.eclipse.rap

Each fragment would only be loaded if the capability is there.
It might be possible to have a context menu if an object address is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant