Improve IO locality in MultiplePathsFromGCRootsComputerImpl bfs

[eclipsewebmaster]

| --- | --- |
| Bugzilla Link | 582821 |
| Status | ASSIGNED |
| Importance | P3 normal |
| Reported | Dec 31, 2023 15:01 EDT |
| Modified | Jan 17, 2024 08:54 EDT |
| Version | 1.15 |

[eclipsewebmaster]

By Jason Koch on Dec 31, 2023 15:03

https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/205956

[eclipsewebmaster]

By Andrew Johnson on Jan 03, 2024 14:44

I think this is okay.
Another case of slow I/O is a HPROF file compressed with gzip (not so much with chucked GZIP as generated by the JVM, or by export HPROF with the chunked option). This can involve restarting the gunzip from a PosStream position, and depending on memory this might be more widely spaced than the 1MB chunked multi-memory gzip file.

[eclipsewebmaster]

By Jason Koch on Jan 16, 2024 17:35

Note that this changes the results presented in the tests because the sort() order changes the traversal order at each BFS layer. Removing the sort during each iteration confirms this.

[eclipsewebmaster]

By Jason Koch on Jan 16, 2024 17:35

the *regression test suite, that is

[jasonk000]

this was merged in [https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/205956 , this commit.

This is as much as stands out to me for now.

[jasonk000]

This is ready to close @krumts but I don't have perms =)

[krumts]

but I don't have perms =)

@jasonk000 , this shouldn't be the case. I was able to close it, and I guess/hope every committer on the project should be able too. Not sure if this is something special for the migrated issues. Will try to figure it out

[krumts]

@jasonk000 I see you are shown as "Contributor" while I am show as "Member" of the eclipse-mat organization. There was an invite after the move. Did you get one? I don't find you under members of the org.

[jasonk000]

I had a look, and I do not see an invite. Checked my spam/deleted as well and did not see it.

[kgibm]

I believe it requires setting your GitHub user ID in the Eclipse developer configuration. Did you do that?

This is the invite email I got:

[krumts]

@jasonk000 the web masters confirmed that the link to your github id is missing. Once you link it, you will automatically get the invitation to join (within 2h).