Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare releng for 4.4.0 #559

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Prepare releng for 4.4.0 #559

merged 3 commits into from
Jun 17, 2024

Conversation

BeckerFrank
Copy link
Contributor

No description provided.

@merks
Copy link
Contributor

merks commented Jun 16, 2024

/request-license-review

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mass version changes are hard to review. 😝

Copy link

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-mylyn/org.eclipse.mylyn/actions/runs/9535962808

@BeckerFrank
Copy link
Contributor Author

Mass version changes are hard to review. 😝

Yes, but if you also have to change the versions for dependencies, it becomes even more difficult.
Maybe we can change some places to work with ranges instead of a fixed version.
Example: bundle-version="[4.4.0,5.0.0)" instead of bundle-version="4.4.0" in the *.MF files

Should I make this change?

@merks
Copy link
Contributor

merks commented Jun 16, 2024

FYI the hamcrest issue this is a glitch.

Yes, I approved the changes.

@BeckerFrank BeckerFrank merged commit d232af5 into main Jun 17, 2024
3 of 4 checks passed
@BeckerFrank BeckerFrank deleted the prepare_releng_for_4.4.0 branch June 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants