Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRIU: Remove debug interpreter #19835

Open
tajila opened this issue Jul 9, 2024 · 0 comments
Open

CRIU: Remove debug interpreter #19835

tajila opened this issue Jul 9, 2024 · 0 comments
Assignees
Labels
comp:vm criu Used to track CRIU snapshot related work

Comments

@tajila
Copy link
Contributor

tajila commented Jul 9, 2024

The debug interpreter was added here, #17245, to do

  1. Enable support for hooks (needed for xtrace and xdump)
  2. Allow one to avoid using the debug interpreter at starup

Now that we have the ability to transition to the debug interpreter on restore, we no longer need the criu interpreter. Instead we can start with the standard interpreter, and transition to the debug interpreter if needed.

Steps

  1. Add a new field in J9CRIUCheckpointState called debugInterpreterRequested
  2. The hooks for criuRestoreInitializeTrace and criuRestoreInitializeDump set the debugInterpreterRequested to true
  3. In checkTransitionToDebugInterpreter check if debugInterpreterRequested is set then attempt to transition to the debug interpreter.
  4. Add a new restore hook (similar to the ones above) and take the code in checkTransitionToDebugInterpreter that looks for the VMOPT_XXDEBUGINTERPRETER and move it to that function. It should set the debugInterpreterRequested if debug interpreter is there.
  5. Move checkTransitionToDebugInterpreter to after runInternalJVMRestoreHooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm criu Used to track CRIU snapshot related work
Projects
None yet
Development

No branches or pull requests

2 participants