Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing java.lang.ref.Reference.waitForReferenceProcessing() for openjdk regression tests for TLS 1.3 #2909

Closed
pshipton opened this issue Sep 18, 2018 · 4 comments

Comments

@pshipton
Copy link
Member

< sun/security/provider/FileInputStreamPool/FileInputStreamPoolTest.java Failed. Execution failed: `main' threw exception: java.lang.Error: java.lang.NoSuchMethodException: java.lang.ref.Reference.waitForReferenceProcessing()

It appears a private method java.lang.ref.Reference.waitForReferenceProcessing() is required.

@JasonFengJ9
Copy link
Member

https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/b44d19c4cbca42541aef5132f21870c1b924a68c/test/jdk/sun/security/provider/FileInputStreamPool/FileInputStreamPoolTest.java#L152-L154

                waitForReferenceProcessingMethod =
                    Reference.class.getDeclaredMethod("waitForReferenceProcessing");
                waitForReferenceProcessingMethod.setAccessible(true);

@LinHu2016 is on this.

@LinHu2016
Copy link
Contributor

I can add new private static method waitForReferenceProcessing() in Reference.java to avoid the issue, but apparently test code (FileInputStreamPoolTest.java) uses unusual reflection way to access private method.

@LinHu2016
Copy link
Contributor

currently plan to add private static method waitForReferenceProcessing() for Java 9 or above, but we can also add it in Java 8 openJ9

@JasonFengJ9
Copy link
Member

It appears this test is against RI specific internal behaviour (a private static method). If there is no usage I would suggest to add it for JDK11 and onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants