Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Unsafe.getAndSet to atomicCompareAndSwapReturnValue in J9RecognizedCallTransformer #2915

Closed
liqunl opened this issue Sep 18, 2018 · 1 comment
Closed

Optimize Unsafe.getAndSet to atomicCompareAndSwapReturnValue in J9RecognizedCallTransformer #2915

liqunl opened this issue Sep 18, 2018 · 1 comment

Comments

@liqunl
Copy link
Contributor

liqunl commented Sep 18, 2018

Current optimization on Unsafe.getAndSet uses atomicCompareAndSwap which returns a boolean. This is incorrect and is to be removed in #2913. The right transformation should use atomicCompareAndSwapReturnValue to return the old value in the given memory location.

The atomicCompareAndSwapReturnValue is to be implemented in eclipse/omr#2174
@liqunl liqunl mentioned this issue Sep 18, 2018
Merged
@liqunl
Copy link
Contributor Author

liqunl commented Sep 19, 2018

Closed because of #2940

@liqunl liqunl closed this as completed Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liqunl