Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a command separator macro in TestConfig/makefile #490

Closed
Mesbah-Alam opened this issue Oct 31, 2017 · 3 comments
Closed

Create a command separator macro in TestConfig/makefile #490

Mesbah-Alam opened this issue Oct 31, 2017 · 3 comments

Comments

@Mesbah-Alam
Copy link
Contributor

We need to create a command separator macro which needs ot be ';' for unix and '&' for Windows.

This results from the fact that we have '' being used in playlist.xml for testkitgen which won't work for WIndows.

Quoting Simon's comment in https://github.com/AdoptOpenJDK/openjdk-systemtest/pull/24/files "\ is not valid in a Windows shell. Instead you could create a macro AND_THEN (or a similar name) with a value of '&' on windows, otherwise ';'. and then use cd $(OPENJDK_SYSTEMTEST_ROOT)/openjdk.build && make test.ClassloadingLoadTest JAVA_ARGS=$(Q)$(JVM_OPTIONS)$(Q) $(AND_THEN) $(TEST_STATUS)"

@llxia
Copy link
Contributor

llxia commented Oct 31, 2017

The command in playlist.xml will be used to generate make target and command. The tests runs ok on windows in the lab machines. What is your error message?

@smlambert
Copy link
Contributor

Is there an update on this? I am going through older issues to see which can be or have been resolved.

@Mesbah-Alam
Copy link
Contributor Author

Thanks for reminding me, Shelley.

This turns out to be a non-issue, as we have the functional tests running on Windows in the eclipse openj9 builds, where ;\ in the command line in playlists didn't create any problem. And also, as Lan had indicated, they are running in jobs in internal build as well. I am therefore closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants