Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

NihmsPassClientService.findJournalByIssn uses incorrect attribute #31

Closed
emetsger opened this issue Apr 29, 2019 · 0 comments · Fixed by #33
Closed

NihmsPassClientService.findJournalByIssn uses incorrect attribute #31

emetsger opened this issue Apr 29, 2019 · 0 comments · Fixed by #33
Assignees
Labels
bug Something isn't working

Comments

@emetsger
Copy link
Contributor

emetsger commented Apr 29, 2019

NihmsPassClientService.findJournalByIssn attempts to find a Journal by ISSN, but uses the incorrect ES attribute issn. Instead, issns (plural) should be used.

An initial assessment indicates this should be corrected:

  • This method (see screenshot) appears to be called by production code.
  • Because a Journal may have multiple ISSNs, the method logic probably needs to be updated to account for this
    /**
     * Look up Journal URI using ISSN
     * @param issn the issn
     * @return
     */
    public URI findJournalByIssn(String issn) {
        if (nullOrEmpty(issn)) {
            return null;      
        }
        return client.findByAttribute(Journal.class, "issn", issn);
    }

Screen Shot 2019-04-29 at 1 09 26 PM

@emetsger emetsger added this to Planned in 2019 - 1st half via automation Apr 29, 2019
@htpvu htpvu added the bug Something isn't working label Apr 29, 2019
@htpvu htpvu moved this from Planned to In progress in 2019 - 1st half Apr 30, 2019
2019 - 1st half automation moved this from In progress to Done week of 4.23 Apr 30, 2019
@eclipsewebmaster eclipsewebmaster removed this from Done week of 4.23 in 2019 - 1st half Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants