Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in the manifest before Require Bundle header throws compilation errors related to missing required bundle #651

Open
alshamams opened this issue Jun 29, 2023 · 1 comment

Comments

@alshamams
Copy link
Contributor

Whenever there is an error in the manifest especially before the Require Bundle header, the compilation errors that arise because of a missing required bundle are clobbered with the manifest parsing error, and this leads to confusion to the user.

459A3210-D544-443C-97B9-184766648C07_1_201_a

@gireeshpunathil
Copy link
Contributor

if (fHeaders == null || getErrorCount() > 0) {
return;
}

The reason as I understood is:

  • if there is at least one error in the manifest, the above logic kicks-in and validation returns
  • this means the budledescription is not built
  • this poses serious issues to the Java compiler, as the Require-Bundle header is not resolved

thinking aloud - why should we abort the validation when there is an error? why can't we proceed to build the bundle description? Will there by any side effect if we remove the check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants