Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated show-close CSS support #159

Closed
vogella opened this issue Jun 20, 2022 · 2 comments · Fixed by #1559
Closed

Remove deprecated show-close CSS support #159

vogella opened this issue Jun 20, 2022 · 2 comments · Fixed by #1559

Comments

@vogella
Copy link
Contributor

vogella commented Jun 20, 2022

Since 2012 we are issuing a warning if the deprecated swt-close CSS property is used. We should remove this property.

@elsazac
Copy link
Member

elsazac commented Jan 25, 2024

@vogella - could you pls elaborate a little on this? where do I see the warning?

@vogella
Copy link
Contributor Author

vogella commented Jan 25, 2024

That @elsazac for showing interest in this issue.

In org.eclipse.e4.ui.css.swt we have

      <handler
            adapter="org.eclipse.e4.ui.css.swt.dom.CTabItemElement"
            composite="false"
            handler="org.eclipse.e4.ui.css.swt.properties.custom.CSSPropertyShowCloseHandler">
         <property-name
               name="swt-show-close">
         </property-name>
             <property-name
               name="show-close" deprecated="renamed as swt-show-close">
         </property-name>
      </handler>

And the code in CSSPropertyShowCloseHandler, CTabFolderTest, CTabItemTest

So the plug-in xml and the code needs to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants