Fix "Terminate and Relaunch" of groups that use adoptIfRunning #1318 #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 737 files ±0 1 737 suites ±0 1h 27m 31s ⏱️ - 13m 14s For more details on these failures, see this check. Results for commit faf27df. ± Comparison against base commit a4776c2. ♻️ This comment has been updated with latest results. |
…e-platform#1318 This was a race condition: RuntimeProcess.fTerminated was only set asynchronously, hindering relaunching the process, thinking it was already running. Happened only for GroupLaunchElement.adoptIfRunning == true fixes eclipse-platform#1318
|
ignoring unrelated random fail ProcessConsoleManagerTests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a race condition:
RuntimeProcess.fTerminated was only set asynchronously, hindering relaunching the process, thinking it was already running.
Happened only for GroupLaunchElement.adoptIfRunning == true
fixes
#1318