Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for action buttons on groups/sections #1439

Closed
5 tasks
pcdavid opened this issue Oct 25, 2022 · 0 comments · Fixed by #1464
Closed
5 tasks

Add support for action buttons on groups/sections #1439

pcdavid opened this issue Oct 25, 2022 · 0 comments · Fixed by #1464

Comments

@pcdavid
Copy link
Member

pcdavid commented Oct 25, 2022

  • Add org.eclipse.sirius.components.forms.Group.buttons : List<org.eclipse.sirius.components.forms.Button>
    • Update the GraphQL Schema, the GroupDescription, GroupComponent etc. to allow the description and rendering of these.
  • Update FormEventFragments to fetch the new field Group { buttons }
  • Update Group.tsx on the front to display the buttons in group's header
    • Actual UI to be defined.
    • Reuse ButtonPropertySection for the actual implementation, but this may be by copy/paste instead of trying to extract some shared code.
  • Update view.ecore to allow the configuration of these buttons from the View DSL.
  • Update the Form Description Editor to allow for adding/removing buttons on groups
    • The Form Description Editor does not support the definition of additional groups. It's basically for designing a single Group. So buttons will be dropped in a single new drop area at the top of the preview area.
@pcdavid pcdavid added this to the 2023.1.0 milestone Oct 25, 2022
pcdavid added a commit that referenced this issue Oct 28, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 28, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 28, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 28, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Oct 28, 2022 that will close this issue
39 tasks
AxelRICHARD pushed a commit that referenced this issue Nov 8, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 8, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 8, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 8, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 8, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 9, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 16, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 16, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 16, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 16, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 16, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 16, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 16, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 16, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 16, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 16, 2022
Fix "Warning: Each Child in a List Should Have a Unique 'key' Prop"

Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 16, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 16, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 18, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 18, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 18, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 18, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 18, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 18, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 18, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 18, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 18, 2022
Fix "Warning: Each Child in a List Should Have a Unique 'key' Prop"

Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 18, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
pcdavid pushed a commit that referenced this issue Nov 21, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
pcdavid added a commit that referenced this issue Nov 21, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
pcdavid pushed a commit that referenced this issue Nov 21, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
pcdavid added a commit that referenced this issue Nov 21, 2022
Bug: #1439
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Nov 21, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
pcdavid pushed a commit that referenced this issue Nov 23, 2022
Bug: #1439
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment