Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the direct edit of the start and end labels of an edge #1463

Closed
sbegaudeau opened this issue Nov 14, 2022 · 1 comment · Fixed by #1578 or #1653
Closed

Add support for the direct edit of the start and end labels of an edge #1463

sbegaudeau opened this issue Nov 14, 2022 · 1 comment · Fixed by #1578 or #1653
Assignees
@sbegaudeau
Labels
difficulty: medium type: enhancement

Comments

@sbegaudeau
Copy link
Member

No description provided.

@mbats mbats assigned pcdavid and sbegaudeau and unassigned pcdavid Nov 28, 2022
sbegaudeau added a commit that referenced this issue Jan 13, 2023
@sbegaudeau
[1463] Add support for the direct edit of the start and end labels of…
7e24dcb 
… an edge

Bug: #1463
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@sbegaudeau sbegaudeau mentioned this issue Jan 13, 2023
Merged
39 tasks
@sbegaudeau sbegaudeau linked a pull request Jan 13, 2023 that will close this issue
[1463] Add support for the direct edit of the start and end labels of an edge #1578
Merged
39 tasks
sbegaudeau added a commit that referenced this issue Jan 23, 2023
@sbegaudeau
[1463] Add support for the direct edit of the start and end labels of…
4ba00e6 
… an edge

Bug: #1463
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 23, 2023
@sbegaudeau
[1463] Add support for the direct edit of the start and end labels of…
802b263 
… an edge

Bug: #1463
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 23, 2023
@sbegaudeau
[1463] Add support for the direct edit of the start and end labels of…
6d02085 
… an edge

Bug: #1463
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 23, 2023
@sbegaudeau
[1463] Add support for the direct edit of the start and end labels of…
a6a1676 
… an edge

Bug: #1463
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 23, 2023
@sbegaudeau
[1463] Add support for the direct edit of the start and end labels of…
f8ee85e 
… an edge

Bug: #1463
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@pcdavid
Copy link
Member

pcdavid commented Jan 31, 2023

This caused a regression: I get an NPE in CompatibilityInitialDirectEditElementLabelProvider when trying to trigger a direct-edit on an edge which does not have begin/end labels. We do edge.getBeginLabel().getId().equals(labelId) but edge.getBeginLabel() can be null.

I'll propose a PR.

@pcdavid pcdavid reopened this Jan 31, 2023
pcdavid added a commit that referenced this issue Jan 31, 2023
@pcdavid
[1463] Fix NPE when triggering direct edit on edges from the compatib…
d86fe15 
…ility layer

Bug:  #1463
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jan 31, 2023
@pcdavid
[1463] Do not assume there is always at least a center label on an edge
c407ef5 
Bug: #1463
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Jan 31, 2023 that will close this issue
Fix issues on edge label edition #1653
Merged
39 tasks
pcdavid added a commit that referenced this issue Feb 3, 2023
@pcdavid
[1463] Fix NPE when triggering direct edit on edges from the compatib…
6496ee1 
…ility layer

Bug:  #1463
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 3, 2023
@pcdavid
[1463] Do not assume there is always at least a center label on an edge
d9114d5 
Bug: #1463
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Feb 3, 2023
@pcdavid @sbegaudeau
[1463] Fix NPE when triggering direct edit on edges from the compatib…
3f2017c 
…ility layer

Bug:  #1463
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Feb 3, 2023
@pcdavid @sbegaudeau
[1463] Do not assume there is always at least a center label on an edge
bff5b86 
Bug: #1463
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Feb 3, 2023
@pcdavid @sbegaudeau
[1463] Fix NPE when triggering direct edit on edges from the compatib…
db6ecc2 
…ility layer

Bug:  #1463
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Feb 3, 2023
@pcdavid @sbegaudeau
[1463] Do not assume there is always at least a center label on an edge
c585e7b 
Bug: #1463
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@jessymallet jessymallet mentioned this issue Jan 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbegaudeau sbegaudeau

Labels
difficulty: medium type: enhancement
Projects
None yet
Milestone
No milestone
2 participants
@pcdavid @sbegaudeau