Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use richer data types for the View DSL #1565

Closed
pcdavid opened this issue Jan 10, 2023 · 0 comments · Fixed by #1784
Closed

Use richer data types for the View DSL #1565

pcdavid opened this issue Jan 10, 2023 · 0 comments · Fixed by #1784

Comments

@pcdavid
Copy link
Member

pcdavid commented Jan 10, 2023

In #1426 we introduced the InterpretedExpression (resp. DomainType) EDataTypes in view.ecore to identify string attributes which are expected to contain AQL expressions (resp. domain type names). This is useful to provide richer details view with widgets more precisely chosen/configured than what the generic choices would make.

There are other kinds of attributes which are currently encoded as raw EString or EInt but could benefit from being more precise:

  • Color (EString): could be represented with a color picker when we get support for that.
  • Dimension or Length: currently any string, but if we (the widget) knew it is supposed to represent a CSS length we could provide some client side validation.
  • Feature(Name) (EString): this is similar to DomainType. It is supposed to reference the name of a meta-model element feature (for example in CreateInstance.referenceName) and could benefit from some completion/validation support with a more precise definition than "a string".

Note that adding these data types would be useful even just in terms of documentation if we do not exploit them immediatly.

@sbegaudeau sbegaudeau modified the milestone: 2023.3.0 Jan 11, 2023
pcdavid added a commit that referenced this issue Mar 2, 2023
Bug: #1565
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 2, 2023
Bug: #1565
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Mar 2, 2023
Bug: #1565
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@sbegaudeau sbegaudeau added this to the 2023.4.0 milestone Mar 2, 2023
@sbegaudeau sbegaudeau linked a pull request Mar 2, 2023 that will close this issue
AxelRICHARD pushed a commit that referenced this issue Mar 2, 2023
Bug: #1565
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants