Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to move a toolbar action from a group to another with no toolbar actions in FormDescriptionEditors #1708

Closed
4 tasks done
AxelRICHARD opened this issue Feb 15, 2023 · 0 comments · Fixed by #1709
Closed
4 tasks done

Impossible to move a toolbar action from a group to another with no toolbar actions in FormDescriptionEditors #1708

AxelRICHARD opened this issue Feb 15, 2023 · 0 comments · Fixed by #1709
Assignees
@AxelRICHARD
Labels
difficulty: starter package: formdescriptioneditors type: bug
Milestone
2023.4.0

Comments

@AxelRICHARD
Copy link
Contributor

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • latest
  • I have specified my environment :
  • All

Screenshots

2023-02-15 15 29 07

Steps to reproduce

  1. Open a FormDescriptionEditor
  2. Add two groups (A and B)
  3. Add a new toolbar action on the first group (A)
  4. Try to move the toolbar action from (A) to (B)

Expected behavior

The toolbar action is moved from the first group to to other one.

Actual behavior

An exception is raised in the snackbar and the move is cancelled.
Note it only happens if the group (B) has no toolbar actions.
@AxelRICHARD AxelRICHARD added this to the 2023.3.0 milestone Feb 15, 2023
AxelRICHARD added a commit that referenced this issue Feb 16, 2023
@AxelRICHARD
[1708] Fix move a toolbar action from a group to another
6c3fb79 
Bug: #1708
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@AxelRICHARD AxelRICHARD changed the title Impossible to move an existing toolbar action from a group to another with no toolbar actions in FormDescriptionEditors Impossible to move a toolbar action from a group to another with no toolbar actions in FormDescriptionEditors Feb 16, 2023
AxelRICHARD added a commit that referenced this issue Feb 16, 2023
@AxelRICHARD
[1708] Fix move a toolbar action from a group to another
a32d4db 
Bug: #1708
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@AxelRICHARD AxelRICHARD self-assigned this Feb 16, 2023
@AxelRICHARD AxelRICHARD mentioned this issue Feb 16, 2023
Merged
39 tasks
@AxelRICHARD AxelRICHARD linked a pull request Feb 16, 2023 that will close this issue
[1708] Fix move a toolbar action from a group to another #1709
Merged
39 tasks
AxelRICHARD added a commit that referenced this issue Feb 17, 2023
@AxelRICHARD
[1708] Fix move a toolbar action from a group to another
452dbe3 
Bug: #1708
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@sbegaudeau sbegaudeau modified the milestones: 2023.3.0, 2023.4.0 Feb 23, 2023
pcdavid pushed a commit that referenced this issue Mar 6, 2023
@AxelRICHARD @pcdavid
[1708] Fix move a toolbar action from a group to another
069f3d3 
Bug: #1708
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
pcdavid pushed a commit that referenced this issue Mar 6, 2023
@AxelRICHARD @pcdavid
[1708] Fix move a toolbar action from a group to another
49b2471 
Bug: #1708
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxelRICHARD AxelRICHARD

Labels
difficulty: starter package: formdescriptioneditors type: bug
Projects
None yet
Milestone
2023.4.0
Development

Successfully merging a pull request may close this issue.

[1708] Fix move a toolbar action from a group to another eclipse-sirius/sirius-web
2 participants
@sbegaudeau @AxelRICHARD