Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct edit on View based diagram element leads to infinite loop #1929

Closed
4 tasks done
AxelRICHARD opened this issue Apr 13, 2023 · 1 comment · Fixed by #1930
Closed
4 tasks done

Direct edit on View based diagram element leads to infinite loop #1929

AxelRICHARD opened this issue Apr 13, 2023 · 1 comment · Fixed by #1930
Assignees
@AxelRICHARD
Labels
difficulty: starter package: view type: bug
Milestone
2023.4.0

Comments

@AxelRICHARD
Copy link
Contributor

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • 2023.3.3
  • I have specified my environment :
  • All

Screenshots

...

Steps to reproduce

Try to direct edit a label on a diagram element based on a View diagram description.

Expected behavior

The direct edit is executed without any errors.

Actual behavior

An infinite loop occurs on the backend side.
@AxelRICHARD AxelRICHARD added this to the 2023.4.0 milestone Apr 13, 2023
@AxelRICHARD AxelRICHARD self-assigned this Apr 13, 2023
AxelRICHARD added a commit that referenced this issue Apr 13, 2023
@AxelRICHARD
[1929] Fix direct edit on View based diagram elements
0d69eb3 
Bug: #1929
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@AxelRICHARD AxelRICHARD mentioned this issue Apr 13, 2023
Merged
39 tasks
@AxelRICHARD AxelRICHARD linked a pull request Apr 13, 2023 that will close this issue
[1929] Fix direct edit on View based diagram elements #1930
Merged
39 tasks
@pcdavid
Copy link
Member

pcdavid commented Apr 13, 2023

Note: this only occurs when editing labels of nodes (not edges).

AxelRICHARD added a commit that referenced this issue Apr 13, 2023
@AxelRICHARD
[1929] Fix direct edit on View based diagram elements
91d9bad 
Bug: #1929
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Apr 13, 2023
@AxelRICHARD
[1929] Fix direct edit on View based diagram elements
c34d79b 
Bug: #1929
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
pcdavid pushed a commit that referenced this issue Apr 13, 2023
@AxelRICHARD @pcdavid
[1929] Fix direct edit on View based diagram elements
1ab0e64 
Bug: #1929
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxelRICHARD AxelRICHARD

Labels
difficulty: starter package: view type: bug
Projects
None yet
Milestone
2023.4.0
Development

Successfully merging a pull request may close this issue.

[1929] Fix direct edit on View based diagram elements eclipse-sirius/sirius-web
2 participants
@pcdavid @AxelRICHARD