Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View-based Forms can no longer be instanciated with 2023.4.0 #1952

Closed
pcdavid opened this issue Apr 28, 2023 · 0 comments · Fixed by #1953
Closed

View-based Forms can no longer be instanciated with 2023.4.0 #1952

pcdavid opened this issue Apr 28, 2023 · 0 comments · Fixed by #1953
Labels
difficulty: medium package: forms package: view type: bug
Milestone
2023.6.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Apr 28, 2023

In 1d3e4f3#diff-67f9c31957f203241dd3af3eaf627223232eb55d8f44aba9fbe9526e2221d878L53 we modified the test to allow the creation of View-based representations, but did it in a way which assumes Diagrams are the only View-based representations that exist.
canHandle(IRepresentationDescription representationDescription) on a View-based form will always return false, which make them imppossible to instanciate.
@sbegaudeau sbegaudeau added this to the 2023.6.0 milestone Apr 28, 2023
@pcdavid pcdavid mentioned this issue Apr 28, 2023
Merged
39 tasks
pcdavid added a commit that referenced this issue Apr 28, 2023
@pcdavid
[DRAFT 1952] Fix regression on View-based Forms creation
303b80e 
Bug: #1952
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Apr 28, 2023 that will close this issue
[1952] Fix regression on View-based Forms creation #1953
Merged
39 tasks
pcdavid added a commit that referenced this issue May 3, 2023
@pcdavid
[1952] Fix regression on View-based Forms creation
72b4d46 
Bug: #1952
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue May 3, 2023
@pcdavid
[1952] Fix regression on View-based Forms creation
7c50162 
Bug: #1952
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue May 5, 2023
@pcdavid
[1952] Fix regression on View-based Forms creation
e27060e 
Bug: #1952
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue May 5, 2023
@pcdavid
[1952] Fix regression on View-based Forms creation
8b538b1 
Bug: #1952
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue May 5, 2023
@pcdavid
[1952] Fix regression on View-based Forms creation
1d9304e 
Bug: #1952
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue May 5, 2023
@pcdavid
[1952] Fix regression on View-based Forms creation
f786256 
Bug: #1952
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue May 9, 2023
@pcdavid @sbegaudeau
[1952] Fix regression on View-based Forms creation
cd3e39f 
Bug: #1952
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@sbegaudeau sbegaudeau changed the title [Regression] View-based Forms can no longer be instanciated with 2023.4.0 View-based Forms can no longer be instanciated with 2023.4.0 May 9, 2023
sbegaudeau pushed a commit that referenced this issue May 9, 2023
@pcdavid @sbegaudeau
[1952] Fix regression on View-based Forms creation
8713795 
Bug: #1952
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue May 9, 2023
@pcdavid @sbegaudeau
[1952] Fix regression on View-based Forms creation
efeafbd 
Bug: #1952
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium package: forms package: view type: bug
Projects
None yet
Milestone
2023.6.0
Development

Successfully merging a pull request may close this issue.

[1952] Fix regression on View-based Forms creation eclipse-sirius/sirius-web
2 participants
@pcdavid @sbegaudeau