Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool reconnection doesn't work anymore for applications with a custom IViewRepresentationDescriptionSearchService #2003

Closed
frouene opened this issue May 30, 2023 · 1 comment · Fixed by #2002
Closed

Tool reconnection doesn't work anymore for applications with a custom IViewRepresentationDescriptionSearchService #2003

frouene opened this issue May 30, 2023 · 1 comment · Fixed by #2002
Assignees
@pcdavid
Labels
package: view type: bug
Milestone
2023.6.0

Comments

@frouene
Copy link
Contributor

frouene commented May 30, 2023

Screenshots

reconnect

Actual behavior

The reconnection tool return an ErrorPayload with an empty message.
@pcdavid pcdavid added this to the 2023.6.0 milestone May 30, 2023
@pcdavid pcdavid linked a pull request May 30, 2023 that will close this issue
Fix reconnection tool for applications with a custom IViewRepresentationDescriptionSearchService #2002
Merged
39 tasks
@pcdavid
Copy link
Member

pcdavid commented May 30, 2023

Actually, tool reconnection works fine in Sirius Web's sample application.

My understanding is that Sirius Components hard-codes in ViewReconnectionToolsExecutor.execute() the logic to locate the EdgeDescription. This hard-coded logic happens to work in the context of Sirius Web, but for other applications which manage their View instances differently, we should delegate to IViewRepresentationDescriptionSearchService.findViewEdgeDescriptionById(String) so that their own implementation of IViewRepresentationDescriptionSearchService, consistent with their View models integration, is used instead.

pcdavid pushed a commit to adaussy/sirius-components that referenced this issue May 30, 2023
@adaussy @pcdavid
[2003] Make reconnection tool more robust
711fa3b 
Delegate the search for the EdgeDescription to
IViewRepresentationDescriptionSearchService so that edge reconnection
can work for applications which customize this service.

Bug: eclipse-sirius#2003
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid changed the title Tool reconnection doesn't work anymore Tool reconnection doesn't work anymore for applications with a custom IViewRepresentationDescriptionSearchService May 30, 2023
@pcdavid pcdavid self-assigned this May 30, 2023
pcdavid pushed a commit to adaussy/sirius-components that referenced this issue May 30, 2023
@adaussy @pcdavid
[2003] Make reconnection tool more robust
445178c 
Delegate the search for the EdgeDescription to
IViewRepresentationDescriptionSearchService so that edge reconnection
can work for applications which customize this service.

Bug: eclipse-sirius#2003
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue May 31, 2023
@adaussy @sbegaudeau
[2003] Make reconnection tool more robust
11b23cc 
Delegate the search for the EdgeDescription to
IViewRepresentationDescriptionSearchService so that edge reconnection
can work for applications which customize this service.

Bug: #2003
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
package: view type: bug
Projects
None yet
Milestone
2023.6.0
2 participants
@pcdavid @frouene