Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion is not enabled on expression fields from custom widgets #2067

Closed
pcdavid opened this issue Jun 14, 2023 · 0 comments · Fixed by #2068
Closed

Completion is not enabled on expression fields from custom widgets #2067

pcdavid opened this issue Jun 14, 2023 · 0 comments · Fixed by #2068

Comments

@pcdavid
Copy link
Member

pcdavid commented Jun 14, 2023

The Slider widget introduced in #1914 defines 3 attributes typed InterpretedExpression.
There are normally rendered with a yellow background and have completion support enabled, but this is not the case for Slider.
This is because the test to detect these InterpretedExpression fields is too strict and assumes all widgets are defined inside the View EPackage itself.

Steps to reproduce:

  1. Create a new FormDescription.
  2. Add a Slider widget inside a Group.
  3. Select the widget in the explorer.

In the Details panel, the 4 expression attributes should be rendered with a yellow background and support completion.

@pcdavid pcdavid added this to the 2023.8.0 milestone Jun 14, 2023
@pcdavid pcdavid self-assigned this Jun 14, 2023
pcdavid added a commit that referenced this issue Jun 14, 2023
Bug: #2067
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Jun 14, 2023 that will close this issue
39 tasks
sbegaudeau pushed a commit that referenced this issue Jun 20, 2023
Bug: #2067
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Jun 20, 2023
Bug: #2067
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Jun 21, 2023
Bug: #2067
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant