Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeItemContextMenuContribution should be Tree-specific #2135

Closed
pcdavid opened this issue Jun 30, 2023 · 0 comments · Fixed by #2136
Closed

TreeItemContextMenuContribution should be Tree-specific #2135

pcdavid opened this issue Jun 30, 2023 · 0 comments · Fixed by #2136
Assignees
@pcdavid
Labels
difficulty: starter package: trees type: enhancement
Milestone
2023.8.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Jun 30, 2023

It's possible to contribute context menu entries to be added to TreeItems, but this is done in a global context (TreeItemContextMenuContext) and TreeItemContextMenuContributionProps#canHandle is only given the TreeItem.
From that it is not possible to discriminate between different trees (not possible at the moment, but coming soon with #2126).

Tree item actions which make sense in the global Explorer may not make sense in other Tree representations (and vice versa).
@pcdavid pcdavid added this to the 2023.8.0 milestone Jun 30, 2023
@pcdavid pcdavid self-assigned this Jun 30, 2023
@pcdavid pcdavid mentioned this issue Jun 30, 2023
Merged
39 tasks
pcdavid added a commit that referenced this issue Jun 30, 2023
@pcdavid
[2135] Allow TreeItemContextMenuContributions to only apply to specif…
5c251ee 
…ic trees

Bug: #2135
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Jun 30, 2023 that will close this issue
[2135] Allow TreeItemContextMenuContributions to only apply to specific trees #2136
Merged
39 tasks
pcdavid added a commit that referenced this issue Jun 30, 2023
@pcdavid
[2135] Allow TreeItemContextMenuContributions to only apply to specif…
6a807c3 
…ic trees

Bug: #2135
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jun 30, 2023
@pcdavid
[2135] Allow TreeItemContextMenuContributions to only apply to specif…
4e8f64d 
…ic trees

Bug: #2135
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jul 3, 2023
@pcdavid
[2135] Allow TreeItemContextMenuContributions to only apply to specif…
8f53b41 
…ic trees

Bug: #2135
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jul 3, 2023
@pcdavid
[2135] Allow TreeItemContextMenuContributions to only apply to specif…
889ccf3 
…ic trees

Bug: #2135
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jul 3, 2023
@pcdavid
[2135] Allow TreeItemContextMenuContributions to only apply to specif…
5c0ffe6 
…ic trees

Bug: #2135
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jul 4, 2023
@pcdavid
[2135] Allow TreeItemContextMenuContributions to only apply to specif…
4a8c5c2 
…ic trees

Bug: #2135
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Jul 4, 2023
@pcdavid @sbegaudeau
[2135] Allow TreeItemContextMenuContributions to only apply to specif…
57fffc1 
…ic trees

Bug: #2135
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: starter package: trees type: enhancement
Projects
None yet
Milestone
2023.8.0
1 participant
@pcdavid