Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to dispose the IEditingContext #944

Closed
sbegaudeau opened this issue Jan 11, 2022 · 0 comments · Fixed by #942
Closed

Add the ability to dispose the IEditingContext #944

sbegaudeau opened this issue Jan 11, 2022 · 0 comments · Fixed by #942
Assignees
@sbegaudeau
Labels
difficulty: medium type: enhancement
Projects
Sirius Components v2022.01.0
Milestone
2022.01.0

Comments

@sbegaudeau
Copy link
Member

When the EditingContextEventProcessor is disposed, we cannot know it from the outside. As a result, it prevent us for example to remove potential listeners on the IEditingContext that may have been registered while loading it.
@sbegaudeau sbegaudeau added this to the 2022.01.0 milestone Jan 11, 2022
@sbegaudeau sbegaudeau added this to To Do in Sirius Components v2022.01.0 via automation Jan 11, 2022
@sbegaudeau sbegaudeau mentioned this issue Jan 11, 2022
Closed
@sbegaudeau sbegaudeau self-assigned this Jan 11, 2022
sbegaudeau added a commit that referenced this issue Jan 11, 2022
@sbegaudeau
[944] Add the ability to dispose the IEditingContext
628bb33 
Bug: #944
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 12, 2022
@sbegaudeau
[944] Add the ability to dispose the IEditingContext
e62e1c2 
Bug: #944
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 12, 2022
@sbegaudeau
[944] Add the ability to dispose the IEditingContext
dfa327b 
Bug: #944
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@sbegaudeau sbegaudeau linked a pull request Jan 12, 2022 that will close this issue
[944] Add the ability to dispose the editing context #942
Merged
Sirius Components v2022.01.0 automation moved this from To Do to Done Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbegaudeau sbegaudeau

Labels
difficulty: medium type: enhancement
Projects
No open projects
Sirius Components v2022.01.0
Done
Milestone
2022.01.0
Development

Successfully merging a pull request may close this issue.

[944] Add the ability to dispose the editing context eclipse-sirius/sirius-web
1 participant
@sbegaudeau