New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1914] Add support for custom widgets (with a simple Slider example) #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
pcdavid
force-pushed
the
pcd/enh/custom-widgets
branch
from
May 3, 2023 14:19
291bea0
to
10522df
Compare
pcdavid
changed the title
Add support for custom widgets (with a simple Slider example)
[1914] Add support for custom widgets (with a simple Slider example)
May 4, 2023
pcdavid
force-pushed
the
pcd/enh/custom-widgets
branch
4 times, most recently
from
May 10, 2023 08:23
20bebe8
to
b0bcaed
Compare
pcdavid
force-pushed
the
pcd/enh/custom-widgets
branch
3 times, most recently
from
May 10, 2023 09:14
c34e7b4
to
9b318e2
Compare
AxelRICHARD
reviewed
May 10, 2023
...ius/components/collaborative/formdescriptioneditors/handlers/AddWidgetEventHandlerTests.java
Show resolved
Hide resolved
...ormdescriptioneditors/frontend/sirius-components-formdescriptioneditors/src/CustomWidget.tsx
Show resolved
Hide resolved
...ormdescriptioneditors/frontend/sirius-components-formdescriptioneditors/src/CustomWidget.tsx
Outdated
Show resolved
Hide resolved
.../java/org/eclipse/sirius/components/collaborative/forms/PropertiesEventProcessorFactory.java
Outdated
Show resolved
Hide resolved
.../org/eclipse/sirius/components/collaborative/forms/RelatedElementsEventProcessorFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/sirius/components/forms/renderer/FormComponentPropsValidator.java
Outdated
Show resolved
Hide resolved
...nts-forms/src/main/java/org/eclipse/sirius/components/forms/renderer/FormElementFactory.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/sirius/components/view/emf/form/ViewFormDescriptionConverterSwitch.java
Show resolved
Hide resolved
AxelRICHARD
reviewed
May 10, 2023
.../src/main/java/org/eclipse/sirius/components/view/emf/form/ViewFormDescriptionConverter.java
Outdated
Show resolved
Hide resolved
pcdavid
force-pushed
the
pcd/enh/custom-widgets
branch
2 times, most recently
from
May 15, 2023 19:33
a27c9b2
to
b44b8e5
Compare
17 tasks
pcdavid
force-pushed
the
pcd/enh/custom-widgets
branch
3 times, most recently
from
May 16, 2023 08:54
189c79b
to
bb9f550
Compare
pcdavid
added
pr: to review soon
priority: high
and removed
pr: to review later
priority: low
labels
May 16, 2023
I'm working on adding the corresponding tests, but the actual implementation is ready for review. |
frouene
requested changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos in the adr
pcdavid
force-pushed
the
pcd/enh/custom-widgets
branch
from
May 22, 2023 10:01
bb9f550
to
5cc6530
Compare
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Bug: #1985 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau
force-pushed
the
pcd/enh/custom-widgets
branch
from
May 25, 2023 09:45
5cc6530
to
86e9342
Compare
Bug: #1914 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Bug: #1914 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Bug: #1914 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau
force-pushed
the
pcd/enh/custom-widgets
branch
from
May 25, 2023 12:06
86e9342
to
6f13f22
Compare
sbegaudeau
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request