Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you, please, put back the java module definitions? #127

Closed
hrstoyanov opened this issue Feb 3, 2024 · 5 comments
Closed

Can you, please, put back the java module definitions? #127

hrstoyanov opened this issue Feb 3, 2024 · 5 comments
Milestone

Comments

@hrstoyanov
Copy link

Is your feature request related to a problem? Please describe.

When trying to integarte Eclipse Store 1.1.0 in Helidon 4, the lack of proper Java 9 module definitions (module-info.java) generates compiler warnings from automatic module assumptions, based on jar names, etc.

Describe the solution you'd like

Put back module definitions (that were removed for some reason). Or, as a temporary solution, add Automatic-Module-Name: to jar's manifests.

Describe alternatives you've considered

I ma currently trying to suppress a lot fo the warnings as part of the Eclipse Sore integration with Helidon

Additional context

I think these module definitions were in MicroStream at asome point, not sure why they were removed?

@hrstoyanov hrstoyanov changed the title Can you put back java module definitions Can you, please, put back the java module definitions? Feb 4, 2024
@fh-ms
Copy link
Contributor

fh-ms commented Feb 7, 2024

We updated some dependencies and ran into build problems, which we couldn't solve. That's why we had to remove the module definitions in order to get the release done.

We will add the automatic-module-name as a temporary solution until we find a way how to solve the build problems.

@hrstoyanov
Copy link
Author

@fh-ms thanks, I see. I fixed the compiler waring in the Helidon integration, but the module name based on jar file names is ... not great. Automatic module names in the jar manifests will help!

@zdenek-jonas
Copy link
Contributor

After some research we have probably found the possibility to return module-info back. Is already merged in main.

@fh-ms fh-ms added this to the 1.2.0 milestone Feb 15, 2024
@hrstoyanov
Copy link
Author

Thanks, but I can update the Helidon 4.x integration pull request, when ES is released officially - for example ES 1.1.1 or 1.2.0 (better). Until then, I can only try the ES main branch locally only.

@zdenek-jonas
Copy link
Contributor

We will prepare the path release next week. It will be 1.1.1. The 1.2.0 will be a little bit later, with Spring update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants